Fix builds to not probe Maven for 1000.0.0 versioned artifacts (#58425) - #58425
Closed
coado wants to merge 1 commit into
Closed
Fix builds to not probe Maven for 1000.0.0 versioned artifacts (#58425)#58425coado wants to merge 1 commit into
1000.0.0 versioned artifacts (#58425)#58425coado wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has imported this pull request. If you are a Meta employee, you can view this in D119646843. |
…ct#58425) Summary: Fixes issue with probing Maven Central repo for artifacts with version `1000.0.0` which are not stored there. The reason is that it creates most of the traffic on Maven Mirror that is forwarded to Maven Central due to artifacts not being cached because they are not found. After this change: - Gradle retains its existing dependency substitutions and forced versions. - Local file-based Maven repositories may still provide 1000.0.0 artifacts. - CocoaPods continues falling back to building React Native from source. - SwiftPM retains its existing 1000.0.0 → nightly resolution behavior. - Published React Native and Hermes versions continue to be queried normally. ## Changelog: [GENERAL][FIXED] - Changed builds to not probe Maven for `1000.0.0` versioned artifacts. Test Plan: Ran `pod install` and build the HelloWorld workspace: ``` [MavenProbe] SKIP https://repo.reactnative.dev/maven2/.../1000.0.0/...reactnative-dependencies-debug.tar.gz [MavenProbe] SKIP https://repo1.maven.org/maven2/.../1000.0.0/...reactnative-dependencies-debug.tar.gz [ReactNativeDependencies] No prebuilt artifacts found, reverting to building from source. [MavenProbe] SKIP https://repo.reactnative.dev/maven2/.../1000.0.0/...reactnative-core-debug.tar.gz [MavenProbe] SKIP https://repo1.maven.org/maven2/.../1000.0.0/...reactnative-core-debug.tar.gz [ReactNativeCore] No prebuilt artifacts found, reverting to building from source. Pod installation complete! There are 85 dependencies from the Podfile and 84 total pods installed. ``` Ran SwiftPM setup on a disposable copy of HelloWorld and built the generated Xcode project. ``` [setup-apple-spm] React Native version: 1000.0.0 [download-spm-artifacts] Detected dev version (1000.0.0), resolving as nightly... [download-spm-artifacts] Resolved nightly: 0.89.0-nightly-20260909-b830082cf [MavenProbe] HEAD https://repo.reactnative.dev/maven2/.../0.89.0-nightly-20260909-b830082cf/...reactnative-core-debug.tar.gz [MavenProbe] HEAD https://repo.reactnative.dev/maven2/.../0.89.0-nightly-20260909-b830082cf/...reactnative-dependencies-debug.tar.gz ``` Published `react-android:1000.0.0` to `/tmp/maven-local`, then ran the repository’s real HelloWorld Android build and a verbose Gradle rebuild. ``` [MavenProbe] SKIP remote Maven https://repo.reactnative.dev/maven2 for React Native 1000.0.0 [MavenProbe] SKIP remote Maven https://repo.maven.apache.org/maven2/ for React Native 1000.0.0 ``` During the HelloWorld build: ``` [MavenProbe] SKIP remote Maven https://repo.maven.apache.org/maven2/ for React Native 1000.0.0 [MavenProbe] SKIP remote Maven https://dl.google.com/dl/android/maven2/ for React Native 1000.0.0 [MavenProbe] SKIP remote Maven https://www.jitpack.io for React Native 1000.0.0 BUILD SUCCESSFUL in 5s ``` Reviewed By: cipolleschi Differential Revision: D119646843 Pulled By: coado
meta-codesync
Bot
changed the title
1000.0.0 versioned artifacts1000.0.0 versioned artifacts (#58425)
coado
force-pushed
the
@coado/maven-probe-fix
branch
from
September 11, 2026 10:47
6e1169c to
2dc1f05
Compare
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119646843. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes issue with probing Maven Central repo for artifacts with version
1000.0.0which are not stored there. The reason is that it creates most of the traffic on Maven Mirror that is forwarded to Maven Central due to artifacts not being cached because they are not found. After this change:Changelog:
[GENERAL][FIXED] - Changed builds to not probe Maven for
1000.0.0versioned artifacts.Test Plan:
Ran
pod installand build the HelloWorld workspace:Ran SwiftPM setup on a disposable copy of HelloWorld and built the generated Xcode project.
Published
react-android:1000.0.0to/tmp/maven-local, then ran the repository’s real HelloWorld Android build and a verbose Gradle rebuild.During the HelloWorld build:
Reviewed By: cipolleschi
Differential Revision: D119646843
Pulled By: coado