Conversation
meta-cla
Bot
added
the
CLA Signed
cortinico
marked this pull request as ready for review
September 9, 2026 13:52
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D119329958. |
|
@cortinico merged this pull request in 9b87159. |
shashikant-panchal
pushed a commit
to shashikant-panchal/react-native
that referenced
this pull request
Sep 10, 2026
Summary: Treat Maestro Cloud uploads stopped by a newer upload as successfully superseded instead of failing the GitHub Actions job. The action still fails the job for test failures, timeouts, and errors, including failures where no upload status is available. This allows the Maestro Cloud “Stop Previous Flows” setting to be re-enabled without creating failure tasks for intentionally superseded runs. Re-enabling that project setting remains a separate dashboard operation. ## Changelog: [INTERNAL] [FIXED] - Do not fail CI when a Maestro Cloud run is superseded Pull Request resolved: react#58422 Test Plan: - `git diff --check` — passed - `./node_modules/.bin/prettier --check .github/workflows/maestro-cloud-rntester.yml` — passed - Exercised the result gate for STOPPED, ERROR, missing-status failure, and SUCCESS outcomes — passed Reviewed By: cipolleschi Differential Revision: D119329958 Pulled By: cortinico fbshipit-source-id: 94dd5efba87f2a9af7261daaee146f839ade380d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Treat Maestro Cloud uploads stopped by a newer upload as successfully superseded instead of failing the GitHub Actions job. The action still fails the job for test failures, timeouts, and errors, including failures where no upload status is available.
This allows the Maestro Cloud “Stop Previous Flows” setting to be re-enabled without creating failure tasks for intentionally superseded runs. Re-enabling that project setting remains a separate dashboard operation.
Changelog:
[INTERNAL] [FIXED] - Do not fail CI when a Maestro Cloud run is superseded
Test Plan:
git diff --check— passed./node_modules/.bin/prettier --check .github/workflows/maestro-cloud-rntester.yml— passed