Wait for Maestro template app startup - #58289
Closed
cortinico wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
cortinico
marked this pull request as ready for review
September 2, 2026 12:35
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D118457123. |
|
@cortinico merged this pull request in 49bcae1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replace the immediate template-app startup assertion with
extendedWaitUntiland a 60-second timeout.The Android ARM64 debug app occasionally becomes accessibility-visible just after the existing assertion times out under native translation. This failed all three attempts in run 33609361836 and run 33540863593. In the captured failure artifact, both the screenshot and XML hierarchy contain
Welcome to React Native, indicating a startup/accessibility timing race rather than an app failure.Release runs remain fast because
extendedWaitUntilreturns as soon as the element is visible.Changelog:
[INTERNAL] [FIXED] - Wait for the template app to become visible in Maestro E2E tests.
Test Plan:
MAESTRO_CLI_NO_ANALYTICS=1 maestro check-syntax scripts/e2e/.maestro/start.yml— passed (OK)./node_modules/.bin/prettier --check scripts/e2e/.maestro/start.yml— passedgit diff --check— passed