Make Maestro keyboard dismissal Android-only - #58288
Open
cortinico wants to merge 1 commit into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
cortinico
marked this pull request as ready for review
September 2, 2026 12:33
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this in D118457013. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Run the RNTester Image flow keyboard dismissal only on Android.
Android needs this step because the keyboard obscures the platform test results control. On iOS, the keyboard can dismiss automatically before Maestro reaches
hideKeyboard, causing the flow to fail withCould not hide the keyboard. This has occurred repeatedly in Maestro Cloud since #58272 landed; for example, run 33517266090.The flow passed in Maestro Cloud iOS while the dismissal was absent, and the existing platform condition syntax is already used by the neighboring Image flows.
Changelog:
[INTERNAL] [FIXED] - Avoid dismissing an already-hidden keyboard in the iOS Maestro Image flow.
Test Plan:
MAESTRO_CLI_NO_ANALYTICS=1 maestro check-syntax packages/rn-tester/.maestro/image.yml— passed (OK)./node_modules/.bin/prettier --check packages/rn-tester/.maestro/image.yml— passedgit diff --check— passedplatform: Android.