Add tests for the PlatformColor lazy color fallback (#57708) - #57708
Closed
Abbondanzo wants to merge 3 commits into
Closed
Add tests for the PlatformColor lazy color fallback (#57708)#57708Abbondanzo wants to merge 3 commits into
Abbondanzo wants to merge 3 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@Abbondanzo has exported this pull request. If you are a Meta employee, you can view the originating Diff in D111917092. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
Summary: An implementation for the RFC in react-native-community/discussions-and-proposals#1008 `PlatformColor` previously had no way to specify what color to use when none of the supplied native color tokens resolve on the device. On a miss the behavior was inconsistent across platforms and architectures (transparent, nil, or a thrown error), giving apps no control over the rendered result. This adds an optional trailing `{fallback: '<raw color string>'}` argument to `PlatformColor(...)` and updates the JS entry points to emit it. The fallback is carried lazily to native as a raw, unprocessed string and is only parsed when every provided token fails to resolve (the native side of that behavior landed earlier in this stack). When at least one token resolves the fallback is ignored, so existing call sites are completely unaffected and omitting the argument preserves today's exact behavior. Example: PlatformColor('someSystemToken', {fallback: '#FF0000'}) Each platform entry point (`PlatformColorValueTypes.{android,ios,macos,windows}.js`, plus the vendored macOS/Windows copies) collects the leading string tokens and, when a trailing `{fallback}` object is present, attaches its raw string to the native color object. Non-string arguments in a non-trailing position are filtered out consistently rather than being forwarded to native. The Flow (`.js.flow`), TypeScript (`.d.ts`), and generated (`ReactNativeApi.d.ts`) declarations widen the signature to `Array<string | {fallback: string}>`, which is backward compatible. Changelog: [General][Added] - Support a lazy raw color fallback for PlatformColor when native tokens fail to resolve Reviewed By: javache, huntie Differential Revision: D113329139
Summary: An implementation for the RFC in react-native-community/discussions-and-proposals#1008 Rounds out the lazy `PlatformColor` fallback with tooling and a demo. - The `react-native/platform-colors` ESLint rule now permits an optional trailing `{fallback: <literal>}` options object so `PlatformColor('token', {fallback: '#RRGGBB'})` is lint-clean, while still requiring every other argument to be a literal. The options object must have exactly one `fallback` property whose value is a literal, so it stays statically analyzable. - A new "Lazy Fallback Colors" section in the RNTester `PlatformColor` example demonstrates valid tokens, misses with no fallback (transparent), and misses with hex / `rgb()` / `rgba()` / `#RRGGBBAA` fallbacks across `backgroundColor`, text `color`, and `borderColor`. Changelog: [Internal] - PlatformColor: ESLint support and RNTester example for the lazy raw-color fallback Reviewed By: christophpurrer Differential Revision: D113329138
Summary: An implementation for the RFC in react-native-community/discussions-and-proposals#1008 Adds unit and integration coverage for the PlatformColor raw-color fallback introduced in the parent diff: - CSSColorTest.cpp: additional CSS `<color>` parse cases pinning the shared parser used on the native fallback path - PlatformColorFallback-itest.js: JS integration test for token-miss -> fallback Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D111917092
meta-codesync
Bot
changed the title
Abbondanzo
force-pushed
the
export-D111917092
branch
from
August 5, 2026 15:21
a74493b to
db4a033
Compare
|
This pull request has been merged in 85e07db. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
An implementation for the RFC in react-native-community/discussions-and-proposals#1008
Adds unit and integration coverage for the PlatformColor raw-color fallback introduced in the parent diff:
<color>parse cases pinning the shared parser used on the native fallback pathChangelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D111917092