RN: Overflow.fromString accepts null and returns non-null (#57638)#57638
Closed
twasilczyk wants to merge 1 commit into
Closed
RN: Overflow.fromString accepts null and returns non-null (#57638)#57638twasilczyk wants to merge 1 commit into
twasilczyk wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@twasilczyk has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113186028. |
Summary: Pull Request resolved: react#57638 Simplifies current and future uses of overflow fields. ReactViewGroup _overflow field is no longer nullable - it's default is now VISIBLE instead of null. The never-set or unrecognized case is no longer detectable, but it's fine - it will just default to VISIBLE, as all uses were already doing so. Differential Revision: D113186028
meta-codesync
Bot
changed the title
twasilczyk
force-pushed
the
export-D113186028
branch
from
July 23, 2026 03:09
351de1b to
cf9edc8
Compare
|
This pull request has been merged in 50a35db. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Simplifies current and future uses of overflow fields.
ReactViewGroup _overflow field is no longer nullable - it's default is now VISIBLE instead of null. The never-set or unrecognized case is no longer detectable, but it's fine - it will just default to VISIBLE, as all uses were already doing so.
Differential Revision: D113186028