codegen: ios platform extensions#57189
Closed
Gregoirevda wants to merge 2 commits into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
Warning Missing Summary Please add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change. Warning Missing Test Plan Please add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested. |
facebook-github-tools
Bot
added
the
Shared with Meta
|
@fabriziocucci has imported this pull request. If you are a Meta employee, you can view this in D113573175. |
|
@fabriziocucci merged this pull request in f46ace8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently codegen doesn't pass the platform file extension. This makes it possible to use
NativeModule.ios.tsand will generate obj-c++ spec files