Skip to content

Commit ebab8d9

Browse files
cortinicometa-codesync[bot]
authored andcommitted
Make Maestro keyboard dismissal Android-only (#58288)
Summary: Run the RNTester Image flow keyboard dismissal only on Android. Android needs this step because the keyboard obscures the platform test results control. On iOS, the keyboard can dismiss automatically before Maestro reaches `hideKeyboard`, causing the flow to fail with `Could not hide the keyboard`. This has occurred repeatedly in Maestro Cloud since #58272 landed; for example, [run 33517266090](https://github.com/react/react-native/actions/runs/33517266090/job/99902026553). The flow passed in Maestro Cloud iOS while the dismissal was absent, and the existing platform condition syntax is already used by the neighboring Image flows. ## Changelog: [INTERNAL] [FIXED] - Avoid dismissing an already-hidden keyboard in the iOS Maestro Image flow. Pull Request resolved: #58288 Test Plan: - `MAESTRO_CLI_NO_ANALYTICS=1 maestro check-syntax packages/rn-tester/.maestro/image.yml` — passed (`OK`) - `./node_modules/.bin/prettier --check packages/rn-tester/.maestro/image.yml` — passed - `git diff --check` — passed - Confirmed the Android dismissal remains present behind `platform: Android`. Reviewed By: christophpurrer Differential Revision: D118457013 Pulled By: cortinico fbshipit-source-id: a8cb212004be0d9eeeff40e148f5d5f7ebee393a
1 parent e0921e9 commit ebab8d9

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

‎packages/rn-tester/.maestro/image.yml‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,11 @@ appId: ${APP_ID} # iOS: com.meta.RNTester.localDevelopment | Android: com.facebo
1414
id: 'example_search'
1515
- inputText:
1616
text: 'Image.getSize'
17-
- hideKeyboard
17+
- runFlow:
18+
when:
19+
platform: Android
20+
commands:
21+
- hideKeyboard
1822
- tapOn:
1923
id: 'platform-test-results'
2024
- assertVisible: 'Results'

0 commit comments

Comments
 (0)