Enable Kotlin warnings as errors (#58390)

Summary:
Pull Request resolved: #58390

K2 warnings can otherwise accumulate unnoticed across React Native Android targets. Enable `warnings_as_errors_k22` by default for `rn_android_library` and clean up the warnings exposed by the RNTester dependency graph. Generated-source targets opt out where warnings cannot be fixed in checked-in source.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D119096917

fbshipit-source-id: 8604536639acb9dde817afef515be696259c1c51

Author: javache

packages/react-native-popup-menu-android/android/src/main/java/com/facebook/react/popupmenu/PopupMenuPackage.kt

@@ -26,7 +26,7 @@ public class PopupMenuPackage() : BaseReactPackage(), ViewManagerOnDemandReactPa
     return null
   }
 
-  protected override fun getViewManagers(reactContext: ReactApplicationContext): List<ModuleSpec> {
+  override fun getViewManagers(reactContext: ReactApplicationContext): List<ModuleSpec> {
     return viewManagersMap.values.toList()
   }
 

packages/react-native-popup-menu-android/android/src/main/java/com/facebook/react/popupmenu/ReactPopupMenuContainer.kt

@@ -25,7 +25,7 @@ public class ReactPopupMenuContainer(context: Context) : FrameLayout(context) {
   public fun showPopupMenu() {
     val view = getChildAt(0)
     val popupMenu = PopupMenu(context, view)
-    var menu = popupMenu.menu
+    val menu = popupMenu.menu
     val items = menuItems
     if (items != null) {
       for (i in 0 until items.size()) {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactActivity.java

@@ -38,6 +38,7 @@ public void handleOnBackPressed() {
         }
       };
 
+  @SuppressWarnings("this-escape")
   protected ReactActivity() {
     mDelegate = createReactActivityDelegate();
   }

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java

@@ -175,7 +175,10 @@ public interface ReactInstanceEventListener
   private final @Nullable JSExceptionHandler mJSExceptionHandler;
   private final @Nullable UIManagerProvider mUIManagerProvider;
   private final @Nullable ReactPackageTurboModuleManagerDelegate.Builder mTMMDelegateBuilder;
+
+  @SuppressWarnings("rawtypes")
   private List<ViewManager> mViewManagers;
+
   private boolean mUseFallbackBundle = true;
   private volatile boolean mInstanceManagerInvalidated = false;
 
@@ -777,7 +780,7 @@ public void destroy() {
       mCurrentActivity = null;
     }
 
-    ResourceDrawableIdHelper.getInstance().clear();
+    ResourceDrawableIdHelper.clear();
 
     mHasStartedDestroying = false;
     synchronized (mHasStartedDestroyingLock) {
@@ -940,6 +943,7 @@ public void detachRootView(ReactRoot reactRoot) {
   }
 
   /** Uses configured {@link ReactPackage} instances to create all view managers. */
+  @SuppressWarnings("rawtypes")
   public List<ViewManager> getOrCreateViewManagers(
       ReactApplicationContext catalystApplicationContext) {
     ReactMarker.logMarker(CREATE_VIEW_MANAGERS_START);
@@ -964,6 +968,7 @@ public List<ViewManager> getOrCreateViewManagers(
     }
   }
 
+  @SuppressWarnings("rawtypes")
   public @Nullable ViewManager createViewManager(String viewManagerName) {
     ReactApplicationContext context;
     synchronized (mReactContextLock) {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java

@@ -117,16 +117,19 @@ public interface ReactRootViewEventListener {
   private int mLastOffsetY = Integer.MIN_VALUE;
   private final AtomicInteger mState = new AtomicInteger(STATE_STOPPED);
 
+  @SuppressWarnings("this-escape")
   public ReactRootView(Context context) {
     super(context);
     init();
   }
 
+  @SuppressWarnings("this-escape")
   public ReactRootView(Context context, AttributeSet attrs) {
     super(context, attrs);
     init();
   }
 
+  @SuppressWarnings("this-escape")
   public ReactRootView(Context context, AttributeSet attrs, int defStyle) {
     super(context, attrs, defStyle);
     init();

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/AnimatedNode.kt

@@ -36,7 +36,7 @@ public abstract class AnimatedNode {
     child.onAttachedToNode(this)
   }
 
-  internal fun removeChild(child: AnimatedNode): Unit {
+  internal fun removeChild(child: AnimatedNode) {
     val currentChildren = children ?: return
     child.onDetachedFromNode(this)
     currentChildren.remove(child)

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/animated/NativeAnimatedModule.kt

@@ -903,9 +903,9 @@ public class NativeAnimatedModule(reactContext: ReactApplicationContext) :
     addUnbatchedOperation(
         object : UIThreadOperation() {
           override fun execute(animatedNodesManager: NativeAnimatedNodesManager) {
-            val reactApplicationContext = reactApplicationContextIfActiveOrWarn
+            // Retained for warning side-effect
+            getReactApplicationContextIfActiveOrWarn()
 
-            var viewTag = -1
             var i = 0
             while (i < opBufferSize) {
               val command = BatchExecutionOpCodes.fromId(opsAndArgs.getInt(i++))
@@ -996,7 +996,7 @@ public class NativeAnimatedModule(reactContext: ReactApplicationContext) :
 
                 BatchExecutionOpCodes.OP_CODE_DISCONNECT_ANIMATED_NODE_FROM_VIEW -> {
                   val animatedNodeTag = opsAndArgs.getInt(i++)
-                  viewTag = opsAndArgs.getInt(i++)
+                  val viewTag = opsAndArgs.getInt(i++)
                   animatedNodesManager.disconnectAnimatedNodeFromView(animatedNodeTag, viewTag)
                 }
 
@@ -1014,7 +1014,7 @@ public class NativeAnimatedModule(reactContext: ReactApplicationContext) :
                     )
 
                 BatchExecutionOpCodes.OP_CODE_REMOVE_ANIMATED_EVENT_FROM_VIEW -> {
-                  viewTag = opsAndArgs.getInt(i++)
+                  val viewTag = opsAndArgs.getInt(i++)
                   animatedNodesManager.removeAnimatedEventFromView(
                       viewTag,
                       checkNotNull(opsAndArgs.getString(i++)),

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/common/ShakeDetector.kt

@@ -34,7 +34,7 @@ constructor(private val shakeListener: ShakeListener, private val minNumShakes:
   private var lastShakeTimestamp: Long = 0
 
   /** Start listening for shakes. */
-  public fun start(manager: SensorManager): Unit {
+  public fun start(manager: SensorManager) {
     val accelerometer = manager.getDefaultSensor(Sensor.TYPE_ACCELEROMETER) ?: return
     sensorManager = manager
     lastTimestamp = -1
@@ -44,7 +44,7 @@ constructor(private val shakeListener: ShakeListener, private val minNumShakes:
   }
 
   /** Stop listening for shakes. */
-  public fun stop(): Unit {
+  public fun stop() {
     sensorManager?.unregisterListener(this)
     sensorManager = null
   }

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/common/SurfaceDelegate.kt

@@ -22,7 +22,7 @@ public interface SurfaceDelegate {
    *
    * @param appKey
    */
-  public fun createContentView(appKey: String): Unit
+  public fun createContentView(appKey: String)
 
   /**
    * Check if the content view is created and ready to be shown
@@ -32,13 +32,13 @@ public interface SurfaceDelegate {
   public fun isContentViewReady(): Boolean
 
   /** Destroy the React content view to avoid memory leak */
-  public fun destroyContentView(): Unit
+  public fun destroyContentView()
 
   /** Show the surface containing the React content view */
-  public fun show(): Unit
+  public fun show()
 
   /** Hide the surface containing the React content view */
-  public fun hide(): Unit
+  public fun hide()
 
   /** Check if the surface is currently showing */
   public fun isShowing(): Boolean

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/common/assets/ReactFontManager.kt

@@ -83,15 +83,15 @@ public class ReactFontManager {
    *
    * ReactFontManager.getInstance().addCustomFont(this, "Srisakdi", R.font.srisakdi);
    */
-  public fun addCustomFont(context: Context, fontFamily: String, fontId: Int): Unit {
+  public fun addCustomFont(context: Context, fontFamily: String, fontId: Int) {
     addCustomFont(fontFamily, ResourcesCompat.getFont(context, fontId))
   }
 
   /**
    * Equivalent method to {@see addCustomFont(Context, String, int)} which accepts a Typeface
    * object.
    */
-  public fun addCustomFont(fontFamily: String, font: Typeface?): Unit {
+  public fun addCustomFont(fontFamily: String, font: Typeface?) {
     if (font != null) {
       customTypefaceCache[fontFamily] = font
     }
@@ -105,7 +105,7 @@ public class ReactFontManager {
    * @see [Typeface.ITALIC]
    * @see [Typeface.BOLD_ITALIC]
    */
-  public fun setTypeface(fontFamilyName: String, style: Int, typeface: Typeface?): Unit {
+  public fun setTypeface(fontFamilyName: String, style: Int, typeface: Typeface?) {
     if (typeface != null) {
       fontCache.getOrPut(fontFamilyName) { AssetFontFamily() }.setTypefaceForStyle(style, typeface)
     }