Don't rely on inline requires to apply mocks in JS tests (#59307)

Summary:
Test only change. RN's own Jest transform (`jest/preprocessor.js`, for this repo's own tests, not public) doesn't include `babel-plugin-jest-hoist`, so `jest.mock` calls run where they're written. Several tests only saw their mocks because inline requires deferred the `require` of the module under test (or of its dependencies) until first use.

That only works for destructured requires like `const {foo} = require('./foo')` while the Babel preset lowers destructuring, which in this config it currently does only as a side effect of lowering generators with regenerator. #59303 removes that, and 114 tests across these 16 suites fail.

This makes the tests install their mocks before the modules under test load, so they pass either way, without diverging Jest's transform from the app's:

- Require modules under test after the `jest.mock` calls that affect them.
- Use mock factories instead of spies or automocks where the code under test binds a function when it loads, or loads an ESM-only package (`octokit/rest`).
- Re-require modules after `jest.resetModules()` where tests reset the registry (`publish-npm`, `Animated`).

The release script tests in particular are dangerous when their mocks silently stop applying - locally, they ran the real version bump against the checkout.

## Changelog:

[INTERNAL] [CHANGED] - Don't rely on inline requires to apply mocks in JS tests

Pull Request resolved: #59307

Test Plan: The full Jest suite passes on this PR (6,284 tests), and with #59303 applied on top (6,285), both under Node 24 with `--no-cache`. Without this PR, #59303 fails 114 tests in 16 suites, matching its CI.

Reviewed By: christophpurrer

Differential Revision: D126757286

Pulled By: javache

fbshipit-source-id: ce39217579aa9805f74786ee9b669bf411e97191

Author: robhogan

.github/workflow-scripts/__tests__/publishTemplate-test.js

@@ -7,11 +7,6 @@
  * @format
  */
 
-const {
-  publishTemplate,
-  verifyPublishedTemplate,
-} = require('../publishTemplate');
-
 const mockRun = jest.fn();
 const mockSleep = jest.fn();
 const mockGetNpmPackageInfo = jest.fn();
@@ -29,6 +24,11 @@ jest.mock('../verifyPublishedPackage.js', () => ({
   verifyPublishedPackage: mockVerifyPublishedPackage,
 }));
 
+const {
+  publishTemplate,
+  verifyPublishedTemplate,
+} = require('../publishTemplate');
+
 const getMockGithub = () => ({
   rest: {
     actions: {

.github/workflow-scripts/__tests__/verifyArtifactsAreOnMaven-test.js

@@ -7,8 +7,6 @@
  * @format
  */
 
-const {verifyArtifactsAreOnMaven} = require('../verifyArtifactsAreOnMaven');
-
 const mockSleep = jest.fn();
 const silence = () => {};
 const mockFetch = jest.fn();
@@ -19,6 +17,8 @@ jest.mock('../utils.js', () => ({
   sleep: mockSleep,
 }));
 
+const {verifyArtifactsAreOnMaven} = require('../verifyArtifactsAreOnMaven');
+
 process.exit = mockExit;
 global.fetch = mockFetch;
 

.github/workflow-scripts/__tests__/verifyPublishedPackage-test.js

@@ -7,8 +7,6 @@
  * @format
  */
 
-const {verifyPublishedPackage} = require('../verifyPublishedPackage');
-
 const mockRun = jest.fn();
 const mockSleep = jest.fn();
 const mockGetNpmPackageInfo = jest.fn();
@@ -23,6 +21,8 @@ jest.mock('../utils.js', () => ({
   getNpmPackageInfo: mockGetNpmPackageInfo,
 }));
 
+const {verifyPublishedPackage} = require('../verifyPublishedPackage');
+
 describe('#verifyPublishedPackage', () => {
   beforeEach(jest.clearAllMocks);
 

.github/workflow-scripts/__tests__/verifyReleaseOnNpm-test.js

@@ -7,8 +7,6 @@
  * @format
  */
 
-const {verifyReleaseOnNpm} = require('../verifyReleaseOnNpm');
-
 const mockVerifyPublishedPackage = jest.fn();
 const silence = () => {};
 
@@ -21,6 +19,8 @@ jest.mock('../verifyPublishedPackage.js', () => ({
   verifyPublishedPackage: mockVerifyPublishedPackage,
 }));
 
+const {verifyReleaseOnNpm} = require('../verifyReleaseOnNpm');
+
 describe('#verifyReleaseOnNPM', () => {
   beforeEach(jest.clearAllMocks);
 

packages/react-native-codegen/src/parsers/__tests__/parsers-commons-test.js

@@ -10,11 +10,33 @@
 
 'use-strict';
 
+// The buildSchema tests spy on `getConfigType`, which parsers-commons reads when
+// it loads, so it's wrapped before any module that uses it is required.
+jest.mock('../utils', () => {
+  const actual = jest.requireActual<Utils>('../utils');
+  return {...actual, getConfigType: jest.fn(actual.getConfigType)};
+});
+
 import type {ParserType} from '../errors';
+import typeof * as Utils from '../utils';
 
-import {FlowParser} from '../flow/parser';
-import {MockedParser} from '../parserMock';
-import {
+const {
+  IncorrectModuleRegistryCallArgumentTypeParserError,
+  IncorrectModuleRegistryCallArityParserError,
+  MisnamedModuleInterfaceParserError,
+  ModuleInterfaceNotFoundParserError,
+  MoreThanOneModuleInterfaceParserError,
+  MoreThanOneModuleRegistryCallsParserError,
+  ParserError,
+  UnsupportedObjectPropertyTypeAnnotationParserError,
+  UntypedModuleRegistryCallParserError,
+  UnusedModuleInterfaceParserError,
+} = require('../errors');
+const {buildComponentSchema} = require('../flow/components');
+const {flowTranslateTypeAnnotation} = require('../flow/modules/index');
+const {FlowParser} = require('../flow/parser');
+const {MockedParser} = require('../parserMock');
+const {
   assertGenericTypeAnnotationHasExactlyOneTypeParameter,
   buildSchema,
   buildSchemaFromConfigType,
@@ -30,22 +52,7 @@ import {
   propertyNames,
   unwrapNullable,
   wrapNullable,
-} from '../parsers-commons';
-
-const {
-  IncorrectModuleRegistryCallArgumentTypeParserError,
-  IncorrectModuleRegistryCallArityParserError,
-  MisnamedModuleInterfaceParserError,
-  ModuleInterfaceNotFoundParserError,
-  MoreThanOneModuleInterfaceParserError,
-  MoreThanOneModuleRegistryCallsParserError,
-  ParserError,
-  UnsupportedObjectPropertyTypeAnnotationParserError,
-  UntypedModuleRegistryCallParserError,
-  UnusedModuleInterfaceParserError,
-} = require('../errors');
-const {buildComponentSchema} = require('../flow/components');
-const {flowTranslateTypeAnnotation} = require('../flow/modules/index');
+} = require('../parsers-commons');
 const {buildModuleSchema} = require('../parsers-commons.js');
 const {Visitor} = require('../parsers-primitives');
 const {wrapComponentSchema} = require('../schema.js');
@@ -665,7 +672,7 @@ describe('buildSchemaFromConfigType', () => {
 });
 
 describe('buildSchema', () => {
-  const getConfigTypeSpy = jest.spyOn(require('../utils'), 'getConfigType');
+  const getConfigTypeSpy = require('../utils').getConfigType;
 
   describe('when there is no codegenNativeComponent and no TurboModule', () => {
     const contents = '';

packages/react-native/Libraries/Animated/__tests__/Animated-test.js

@@ -12,13 +12,13 @@ import * as React from 'react';
 
 const {PlatformColor} = require('../../StyleSheet/PlatformColorValueTypes');
 let Animated = require('../Animated').default;
-const AnimatedProps = require('../nodes/AnimatedProps').default;
-const {
+let AnimatedProps = require('../nodes/AnimatedProps').default;
+let {
   create,
   unmount,
   update,
 } = require('@react-native/jest-preset/jest/renderer');
-const TestRenderer = require('react-test-renderer');
+let TestRenderer = require('react-test-renderer');
 
 // WORKAROUND: `jest.runAllTicks` skips tasks scheduled w/ `queueMicrotask`.
 function mockQueueMicrotask() {
@@ -37,6 +37,16 @@ function mockQueueMicrotask() {
 describe('Animated', () => {
   beforeEach(() => {
     jest.resetModules();
+    // Reload after the reset, so that Animated and the renderer share a copy
+    // of React.
+    Animated = require('../Animated').default;
+    AnimatedProps = require('../nodes/AnimatedProps').default;
+    ({
+      create,
+      unmount,
+      update,
+    } = require('@react-native/jest-preset/jest/renderer'));
+    TestRenderer = require('react-test-renderer');
   });
 
   mockQueueMicrotask();

packages/react-native/Libraries/LogBox/__tests__/LogBoxInspectorContainer-test.js

@@ -10,15 +10,6 @@
 
 'use strict';
 
-const BackHandler: $FlowFixMe = require('../../Utilities/BackHandler').default;
-const LogBoxData = require('../Data/LogBoxData');
-const LogBoxLog = require('../Data/LogBoxLog').default;
-const {
-  _LogBoxInspectorContainer: LogBoxInspectorContainer,
-} = require('../LogBoxInspectorContainer');
-const render = require('@react-native/jest-preset/jest/renderer');
-const React = require('react');
-
 // Mock `LogBoxInspector` because we are interested in snapshotting the behavior
 // of `LogBoxInspectorContainer`, not `LogBoxInspector`.
 jest.mock('../UI/LogBoxInspector', () => ({
@@ -30,6 +21,15 @@ jest.mock('../../Utilities/BackHandler', () =>
   require('../../Utilities/__mocks__/BackHandler'),
 );
 
+const BackHandler: $FlowFixMe = require('../../Utilities/BackHandler').default;
+const LogBoxData = require('../Data/LogBoxData');
+const LogBoxLog = require('../Data/LogBoxLog').default;
+const {
+  _LogBoxInspectorContainer: LogBoxInspectorContainer,
+} = require('../LogBoxInspectorContainer');
+const render = require('@react-native/jest-preset/jest/renderer');
+const React = require('react');
+
 describe('LogBoxInspectorContainer', () => {
   let output;
 

packages/react-native/Libraries/LogBox/__tests__/LogBoxNotificationContainer-test.js

@@ -10,13 +10,6 @@
 
 'use strict';
 
-const BackHandler: $FlowFixMe = require('../../Utilities/BackHandler').default;
-const LogBoxData = require('../Data/LogBoxData');
-const LogBoxLog = require('../Data/LogBoxLog').default;
-const {LogBoxNotificationContainer} = require('../LogBoxNotificationContainer');
-const render = require('@react-native/jest-preset/jest/renderer');
-const React = require('react');
-
 // Mock `LogBoxLogNotification` because we are interested in snapshotting the
 // behavior of `LogBoxNotificationContainer`, not `LogBoxLogNotification`.
 jest.mock('../UI/LogBoxNotification', () => ({
@@ -28,6 +21,13 @@ jest.mock('../../Utilities/BackHandler', () =>
   require('../../Utilities/__mocks__/BackHandler'),
 );
 
+const BackHandler: $FlowFixMe = require('../../Utilities/BackHandler').default;
+const LogBoxData = require('../Data/LogBoxData');
+const LogBoxLog = require('../Data/LogBoxLog').default;
+const {LogBoxNotificationContainer} = require('../LogBoxNotificationContainer');
+const render = require('@react-native/jest-preset/jest/renderer');
+const React = require('react');
+
 describe('LogBoxNotificationContainer', () => {
   let output;
 

packages/react-native/scripts/ios-prebuild/__tests__/headers-xcframework-test.js

@@ -10,11 +10,18 @@
 
 'use strict';
 
+// headers-xcframework reads `execFileSync` when it loads, so it's mocked before
+// the module is required.
+const mockExecFileSync = jest.fn();
+jest.mock('node:child_process', () => ({
+  ...jest.requireActual('node:child_process'),
+  execFileSync: mockExecFileSync,
+}));
+
 const {
   buildDepsHeadersXcframework,
   stubSlicesFromXcframework,
 } = require('../headers-xcframework');
-const childProcess = require('node:child_process');
 const fs = require('node:fs');
 const os = require('node:os');
 const path = require('node:path');
@@ -67,9 +74,9 @@ describe('stubSlicesFromXcframework', () => {
   // SupportedPlatform/Variant -> key mapping and the unknown-slice guard can be
   // tested without a real xcframework or macOS tooling.
   const mockPlist = (obj /*: unknown */) =>
-    jest
-      .spyOn(childProcess, 'execFileSync')
-      .mockReturnValue(Buffer.from(JSON.stringify(obj) ?? '', 'utf8'));
+    mockExecFileSync.mockReturnValue(
+      Buffer.from(JSON.stringify(obj) ?? '', 'utf8'),
+    );
 
   afterEach(() => {
     jest.restoreAllMocks();

packages/react-native/scripts/swiftpm/__tests__/headers-utils-test.js

@@ -10,6 +10,12 @@
 
 'use strict';
 
+// Mock all required modules
+jest.mock('../utils');
+jest.mock('../headers-mappings');
+jest.mock('node:fs');
+jest.mock('node:path');
+
 const {
   symlinkCodegenHeaders,
   symlinkHeadersFromPath,
@@ -18,12 +24,6 @@ const {
   symlinkThirdPartyDependenciesHeaders,
 } = require('../headers-utils');
 
-// Mock all required modules
-jest.mock('../utils');
-jest.mock('../headers-mappings');
-jest.mock('node:fs');
-jest.mock('node:path');
-
 describe('symlinkHeadersFromPath', () => {
   let mockUtils;
   let mockFs;