Skip to content

Commit 9747f39

Browse files
j-piaseckifacebook-github-bot
authored andcommitted
Make core Dynamic* and ReactRootViewTagGenerator headers for-frameworks (#58884)
Summary: `DynamicEventPayload.h`, `DynamicPointerEvent.h`, `DynamicPropsUtilities.h` and `ReactRootViewTagGenerator.h` are used by React Native's own sources and by platform and host integrations, not by component code, so they move from the public to the "for frameworks" tier of the C++ stable API and leave the `<React/RendererCore.h>` umbrella. Consumers that opt into `RN_STRICT_API` get a warning if they include these headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert. Changelog: [Internal] Differential Revision: D123610705
1 parent d08d8d2 commit 9747f39

5 files changed

Lines changed: 4 additions & 8 deletions

File tree

‎packages/react-native/ReactCommon/react/renderer/core/DynamicEventPayload.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <folly/dynamic.h>
1313
#include <react/renderer/core/EventPayload.h>

‎packages/react-native/ReactCommon/react/renderer/core/DynamicPointerEvent.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <folly/dynamic.h>
1313
#include <react/renderer/core/DynamicEventPayload.h>

‎packages/react-native/ReactCommon/react/renderer/core/DynamicPropsUtilities.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <folly/dynamic.h>
1313
#include <react/renderer/core/RawProps.h>

‎packages/react-native/ReactCommon/react/renderer/core/React/RendererCore.h‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,6 @@
3838
#include <react/renderer/core/ConcreteComponentDescriptor.h>
3939
#include <react/renderer/core/ConcreteShadowNode.h>
4040
#include <react/renderer/core/ConcreteState.h>
41-
#include <react/renderer/core/DynamicEventPayload.h>
42-
#include <react/renderer/core/DynamicPointerEvent.h>
43-
#include <react/renderer/core/DynamicPropsUtilities.h>
4441
#include <react/renderer/core/EventBeat.h>
4542
#include <react/renderer/core/EventDispatcher.h>
4643
#include <react/renderer/core/EventEmitter.h>
@@ -67,7 +64,6 @@
6764
#include <react/renderer/core/RawPropsParser.h>
6865
#include <react/renderer/core/ReactEventPriority.h>
6966
#include <react/renderer/core/ReactPrimitives.h>
70-
#include <react/renderer/core/ReactRootViewTagGenerator.h>
7167
#include <react/renderer/core/Sealable.h>
7268
#include <react/renderer/core/ShadowNode.h>
7369
#include <react/renderer/core/ShadowNodeFamily.h>

‎packages/react-native/ReactCommon/react/renderer/core/ReactRootViewTagGenerator.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <react/renderer/core/ReactPrimitives.h>
1313

0 commit comments

Comments
 (0)