Skip to content

Commit 5cd5e39

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Cover cxxreact:tracesection with Stable API guards (#58400)
Summary: Pull Request resolved: #58400 Classifies `cxxreact:tracesection` as a "for frameworks" target under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get a warning if they include its headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: javache Differential Revision: D119163904 fbshipit-source-id: 8c118b4fee6498bda3c33a3a12a38870fc33e4fe
1 parent 4078468 commit 5cd5e39

3 files changed

Lines changed: 6 additions & 0 deletions

File tree

‎packages/react-native/ReactCommon/cxxreact/ReactMarker.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include <cmath>
1113
#include <functional>
1214
#include <mutex>

‎packages/react-native/ReactCommon/cxxreact/SystraceSection.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#include "TraceSection.h"
1113

1214
// NOTE: This is here for a backwards compatibility and should be removed once

‎packages/react-native/ReactCommon/cxxreact/TraceSection.h‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/FrameworksGuard.h>
11+
1012
#ifdef WITH_FBSYSTRACE
1113
#include <fbsystrace.h>
1214
#endif

0 commit comments

Comments
 (0)