Skip to content

Commit 485c1da

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Upgrade ScrollView visibility to "for frameworks" (#58287)
Summary: Pull Request resolved: #58287 Reclassifies `react/renderer/components/scrollview:scrollview` from public to "for frameworks" under the C++ stable API three-tier visibility model. Consumers that opt into `RN_STRICT_API` now get a suppressible warning where they previously got an error pointing at the umbrella, and can acknowledge it with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D118440409
1 parent 44155d0 commit 485c1da

16 files changed

Lines changed: 14 additions & 75 deletions

File tree

packages/react-native/ReactCommon/React-Fabric.podspec

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -154,13 +154,7 @@ Pod::Spec.new do |s|
154154
ss.subspec "scrollview" do |sss|
155155
sss.source_files = podspec_sources("react/renderer/components/scrollview/**/*.{m,mm,cpp,h}", "react/renderer/components/scrollview/**/*.{h}")
156156
sss.header_dir = "react/renderer/components/scrollview"
157-
sss.exclude_files = "react/renderer/components/scrollview/tests", "react/renderer/components/scrollview/platform/android", "react/renderer/components/scrollview/React"
158-
end
159-
160-
ss.subspec "scrollviewUmbrella" do |sss|
161-
sss.source_files = "react/renderer/components/scrollview/React/*.h"
162-
sss.header_dir = ""
163-
sss.header_mappings_dir = "react/renderer/components/scrollview"
157+
sss.exclude_files = "react/renderer/components/scrollview/tests", "react/renderer/components/scrollview/platform/android"
164158
end
165159

166160
ss.subspec "legacyviewmanagerinterop" do |sss|

packages/react-native/ReactCommon/react/renderer/components/scrollview/BaseScrollViewProps.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <react/renderer/components/scrollview/primitives.h>
1313
#include <react/renderer/components/view/ViewProps.h>

packages/react-native/ReactCommon/react/renderer/components/scrollview/React/ScrollView.h

Lines changed: 0 additions & 48 deletions
This file was deleted.

packages/react-native/ReactCommon/react/renderer/components/scrollview/ScrollEvent.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <folly/dynamic.h>
1313
#include <react/renderer/core/EventPayload.h>

packages/react-native/ReactCommon/react/renderer/components/scrollview/ScrollViewComponentDescriptor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <react/renderer/components/scrollview/ScrollViewShadowNode.h>
1313
#include <react/renderer/core/ConcreteComponentDescriptor.h>

packages/react-native/ReactCommon/react/renderer/components/scrollview/ScrollViewEventEmitter.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <memory>
1313

packages/react-native/ReactCommon/react/renderer/components/scrollview/ScrollViewProps.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <react/renderer/components/scrollview/HostPlatformScrollViewProps.h>
1313

packages/react-native/ReactCommon/react/renderer/components/scrollview/ScrollViewShadowNode.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <react/renderer/components/scrollview/ScrollViewEventEmitter.h>
1313
#include <react/renderer/components/scrollview/ScrollViewProps.h>

packages/react-native/ReactCommon/react/renderer/components/scrollview/ScrollViewState.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <react/renderer/graphics/Float.h>
1313
#include <react/renderer/graphics/Point.h>

packages/react-native/ReactCommon/react/renderer/components/scrollview/conversions.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <react/renderer/components/scrollview/primitives.h>
1313
#include <react/renderer/core/PropsParserContext.h>

0 commit comments

Comments
 (0)