Skip to content

Commit 229b893

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Use public umbrellas in animationbackend headers (#58734)
Summary: Pull Request resolved: #58734 Route public C++ dependencies of the `react/renderer/animationbackend` headers through their supported umbrella entry points (`<React/View.h>`, `<React/RendererCore.h>`, `<React/Graphics.h>`, `<React/Timing.h>`, `<React/CallInvoker.h>`), so framework consumers can use the module with strict API enforcement enabled. `react/renderer/uimanager` includes are unchanged since that module has no umbrella and its headers are "for frameworks". Changelog: [Internal] Reviewed By: cortinico Differential Revision: D122327976 fbshipit-source-id: fcb278e2a56c8d671e500e5f676140f8bf01f9bb
1 parent 5d79b8e commit 229b893

8 files changed

Lines changed: 15 additions & 9 deletions

File tree

‎packages/react-native/ReactCommon/React-Fabric.podspec‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,10 @@ Pod::Spec.new do |s|
7272
end
7373

7474
s.subspec "animationbackend" do |ss|
75+
ss.dependency "React-Fabric/coreUmbrella"
76+
ss.dependency "React-Fabric/components/viewUmbrella"
77+
ss.dependency "React-callinvoker"
78+
ss.dependency "React-timing"
7579
ss.source_files = podspec_sources("react/renderer/animationbackend/**/*.{m,mm,cpp,h}", "react/renderer/animationbackend/**/*.{h}")
7680
ss.header_dir = "react/renderer/animationbackend"
7781
end

‎packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedProps.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
#include <react/cxxstableapi/FrameworksGuard.h>
1111

12-
#include <react/renderer/components/view/BaseViewProps.h>
12+
#include <React/View.h>
1313

1414
#include <utility>
1515

‎packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsBuilder.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99

1010
#include <react/cxxstableapi/FrameworksGuard.h>
1111

12-
#include <react/renderer/components/view/BaseViewProps.h>
13-
#include <react/renderer/graphics/Filter.h>
12+
#include <React/Graphics.h>
13+
#include <React/View.h>
1414
#include "AnimatedProps.h"
1515

1616
namespace facebook::react {

‎packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsRegistry.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99

1010
#include <react/cxxstableapi/FrameworksGuard.h>
1111

12+
#include <React/RendererCore.h>
13+
#include <React/View.h>
1214
#include <folly/dynamic.h>
13-
#include <react/renderer/components/view/BaseViewProps.h>
14-
#include <react/renderer/core/ReactPrimitives.h>
1515
#include <react/renderer/uimanager/UIManager.h>
1616
#include <react/renderer/uimanager/UIManagerCommitHook.h>
1717
#include "AnimatedProps.h"

‎packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackend.h‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99

1010
#include <react/cxxstableapi/FrameworksGuard.h>
1111

12-
#include <ReactCommon/CallInvoker.h>
13-
#include <react/renderer/core/ReactPrimitives.h>
12+
#include <React/CallInvoker.h>
13+
#include <React/RendererCore.h>
1414
#include <react/renderer/uimanager/UIManager.h>
1515
#include <react/renderer/uimanager/UIManagerAnimationBackend.h>
1616
#include <functional>

‎packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackendCommitHook.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
#include <react/cxxstableapi/FrameworksGuard.h>
1111

12-
#include <react/renderer/core/ReactPrimitives.h>
12+
#include <React/RendererCore.h>
1313
#include <react/renderer/uimanager/UIManager.h>
1414
#include <react/renderer/uimanager/UIManagerCommitHook.h>
1515
#include "AnimatedPropsRegistry.h"

‎packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationChoreographer.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99

1010
#include <react/cxxstableapi/FrameworksGuard.h>
1111

12+
#include <React/Timing.h>
1213
#include <react/renderer/uimanager/UIManagerAnimationBackend.h>
13-
#include <react/timing/primitives.h>
1414

1515
namespace facebook::react {
1616

‎packages/react-native/ReactCommon/react/renderer/animationbackend/CMakeLists.txt‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,15 @@ add_library(react_renderer_animationbackend OBJECT ${react_renderer_animationbac
1414
target_include_directories(react_renderer_animationbackend PUBLIC ${REACT_COMMON_DIR})
1515

1616
target_link_libraries(react_renderer_animationbackend
17+
callinvoker
1718
react_codegen_rncore
1819
react_cxxstableapi
1920
react_debug
2021
react_renderer_core
2122
react_renderer_graphics
2223
react_renderer_mounting
2324
react_renderer_uimanager
25+
react_timing
2426
glog
2527
folly_runtime
2628
)

0 commit comments

Comments
 (0)