Skip to content

Commit 118211c

Browse files
j-piaseckimeta-codesync[bot]
j-piasecki
authored and
meta-codesync[bot]
committed
Make core Dynamic* and ReactRootViewTagGenerator headers for-frameworks (#58884)
Summary: Pull Request resolved: #58884 `DynamicEventPayload.h`, `DynamicPointerEvent.h`, `DynamicPropsUtilities.h` and `ReactRootViewTagGenerator.h` are used by React Native's own sources and by platform and host integrations, not by component code, so they move from the public to the "for frameworks" tier of the C++ stable API and leave the `<React/RendererCore.h>` umbrella. Consumers that opt into `RN_STRICT_API` get a warning if they include these headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert. Changelog: [Internal] Reviewed By: javache Differential Revision: D123610705 fbshipit-source-id: abccec4b8c2e317587fec939facfe10ba8b049e2
1 parent cf58381 commit 118211c

14 files changed

Lines changed: 4 additions & 206 deletions

‎packages/react-native/ReactCommon/react/renderer/core/DynamicEventPayload.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <folly/dynamic.h>
1313
#include <react/renderer/core/EventPayload.h>

‎packages/react-native/ReactCommon/react/renderer/core/DynamicPointerEvent.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <folly/dynamic.h>
1313
#include <react/renderer/core/DynamicEventPayload.h>

‎packages/react-native/ReactCommon/react/renderer/core/DynamicPropsUtilities.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <folly/dynamic.h>
1313
#include <react/renderer/core/RawProps.h>

‎packages/react-native/ReactCommon/react/renderer/core/React/RendererCore.h‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,6 @@
3838
#include <react/renderer/core/ConcreteComponentDescriptor.h>
3939
#include <react/renderer/core/ConcreteShadowNode.h>
4040
#include <react/renderer/core/ConcreteState.h>
41-
#include <react/renderer/core/DynamicEventPayload.h>
42-
#include <react/renderer/core/DynamicPointerEvent.h>
43-
#include <react/renderer/core/DynamicPropsUtilities.h>
4441
#include <react/renderer/core/EventBeat.h>
4542
#include <react/renderer/core/EventDispatcher.h>
4643
#include <react/renderer/core/EventEmitter.h>
@@ -67,7 +64,6 @@
6764
#include <react/renderer/core/RawPropsParser.h>
6865
#include <react/renderer/core/ReactEventPriority.h>
6966
#include <react/renderer/core/ReactPrimitives.h>
70-
#include <react/renderer/core/ReactRootViewTagGenerator.h>
7167
#include <react/renderer/core/Sealable.h>
7268
#include <react/renderer/core/ShadowNode.h>
7369
#include <react/renderer/core/ShadowNodeFamily.h>

‎packages/react-native/ReactCommon/react/renderer/core/ReactRootViewTagGenerator.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <react/renderer/core/ReactPrimitives.h>
1313

‎scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api‎

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,6 @@ facebook::react::SharedColor facebook::react::colorFromRGBA(uint8_t r, uint8_t g
520520
facebook::react::SharedColor facebook::react::parsePlatformColor(const facebook::react::ContextContainer& contextContainer, int32_t surfaceId, const facebook::react::RawValue& value);
521521
facebook::react::SharedColor facebook::react::whiteColor();
522522
facebook::react::Size facebook::react::yogaMeassureToSize(int64_t value);
523-
facebook::react::SurfaceId facebook::react::getNextRootViewTag() noexcept;
524523
facebook::react::TurboModuleMethodValueKind facebook::react::getTurboModuleMethodValueKind(facebook::jsi::Runtime& rt, const facebook::jsi::Value* value);
525524
facebook::react::ValueUnit facebook::react::toValueUnit(const facebook::react::RawValue& value);
526525
facebook::yoga::FloatOptional facebook::react::convertAspectRatio(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value);
@@ -530,8 +529,6 @@ float facebook::react::blueFromHostPlatformColor(facebook::react::Color color);
530529
float facebook::react::greenFromHostPlatformColor(facebook::react::Color color);
531530
float facebook::react::redFromHostPlatformColor(facebook::react::Color color);
532531
float facebook::react::yogaFloatFromFloat(facebook::react::Float value);
533-
folly::dynamic facebook::react::diffDynamicProps(const folly::dynamic& oldProps, const folly::dynamic& newProps);
534-
folly::dynamic facebook::react::mergeDynamicProps(const folly::dynamic& source, const folly::dynamic& patch, facebook::react::NullValueStrategy nullValueStrategy);
535532
folly::dynamic facebook::react::toDynamic(const YGValue& dimension);
536533
folly::dynamic facebook::react::toDynamic(const facebook::react::BackgroundImage& backgroundImage);
537534
folly::dynamic facebook::react::toDynamic(const facebook::react::BoxShadow& boxShadow);
@@ -2927,11 +2924,6 @@ enum facebook::react::ModalHostViewSupportedOrientations : facebook::react::Moda
29272924
PortraitUpsideDown,
29282925
}
29292926

2930-
enum facebook::react::NullValueStrategy {
2931-
Ignore,
2932-
Override,
2933-
}
2934-
29352927
enum facebook::react::OutlineStyle : uint8_t {
29362928
Dashed,
29372929
Dotted,
@@ -3289,20 +3281,6 @@ struct facebook::react::DropShadowParams {
32893281
public folly::dynamic toDynamic() const;
32903282
}
32913283

3292-
struct facebook::react::DynamicEventPayload : public facebook::react::EventPayload {
3293-
protected folly::dynamic payload_;
3294-
public DynamicEventPayload(folly::dynamic&& payload);
3295-
public static facebook::react::SharedEventPayload create(folly::dynamic&& payload);
3296-
public virtual facebook::jsi::Value asJSIValue(facebook::jsi::Runtime& runtime) const override;
3297-
public virtual facebook::react::EventPayloadType getType() const override;
3298-
public virtual std::optional<double> extractValue(const std::vector<std::string>&) const override;
3299-
}
3300-
3301-
struct facebook::react::DynamicPointerEvent : public facebook::react::DynamicEventPayload {
3302-
public DynamicPointerEvent(folly::dynamic&& payload);
3303-
public const std::optional<std::vector<facebook::react::Tag>>& getHitPathForEventListener() const;
3304-
}
3305-
33063284
struct facebook::react::EventPayload {
33073285
public EventPayload() = default;
33083286
public EventPayload(const facebook::react::EventPayload&) = default;

‎scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api‎

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,6 @@ facebook::react::SharedColor facebook::react::colorFromRGBA(uint8_t r, uint8_t g
520520
facebook::react::SharedColor facebook::react::parsePlatformColor(const facebook::react::ContextContainer& contextContainer, int32_t surfaceId, const facebook::react::RawValue& value);
521521
facebook::react::SharedColor facebook::react::whiteColor();
522522
facebook::react::Size facebook::react::yogaMeassureToSize(int64_t value);
523-
facebook::react::SurfaceId facebook::react::getNextRootViewTag() noexcept;
524523
facebook::react::TurboModuleMethodValueKind facebook::react::getTurboModuleMethodValueKind(facebook::jsi::Runtime& rt, const facebook::jsi::Value* value);
525524
facebook::react::ValueUnit facebook::react::toValueUnit(const facebook::react::RawValue& value);
526525
facebook::yoga::FloatOptional facebook::react::convertAspectRatio(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value);
@@ -530,8 +529,6 @@ float facebook::react::blueFromHostPlatformColor(facebook::react::Color color);
530529
float facebook::react::greenFromHostPlatformColor(facebook::react::Color color);
531530
float facebook::react::redFromHostPlatformColor(facebook::react::Color color);
532531
float facebook::react::yogaFloatFromFloat(facebook::react::Float value);
533-
folly::dynamic facebook::react::diffDynamicProps(const folly::dynamic& oldProps, const folly::dynamic& newProps);
534-
folly::dynamic facebook::react::mergeDynamicProps(const folly::dynamic& source, const folly::dynamic& patch, facebook::react::NullValueStrategy nullValueStrategy);
535532
folly::dynamic facebook::react::toDynamic(const YGValue& dimension);
536533
folly::dynamic facebook::react::toDynamic(const facebook::react::BackgroundImage& backgroundImage);
537534
folly::dynamic facebook::react::toDynamic(const facebook::react::BoxShadow& boxShadow);
@@ -2920,11 +2917,6 @@ enum facebook::react::ModalHostViewSupportedOrientations : facebook::react::Moda
29202917
PortraitUpsideDown,
29212918
}
29222919

2923-
enum facebook::react::NullValueStrategy {
2924-
Ignore,
2925-
Override,
2926-
}
2927-
29282920
enum facebook::react::OutlineStyle : uint8_t {
29292921
Dashed,
29302922
Dotted,
@@ -3282,20 +3274,6 @@ struct facebook::react::DropShadowParams {
32823274
public folly::dynamic toDynamic() const;
32833275
}
32843276

3285-
struct facebook::react::DynamicEventPayload : public facebook::react::EventPayload {
3286-
protected folly::dynamic payload_;
3287-
public DynamicEventPayload(folly::dynamic&& payload);
3288-
public static facebook::react::SharedEventPayload create(folly::dynamic&& payload);
3289-
public virtual facebook::jsi::Value asJSIValue(facebook::jsi::Runtime& runtime) const override;
3290-
public virtual facebook::react::EventPayloadType getType() const override;
3291-
public virtual std::optional<double> extractValue(const std::vector<std::string>&) const override;
3292-
}
3293-
3294-
struct facebook::react::DynamicPointerEvent : public facebook::react::DynamicEventPayload {
3295-
public DynamicPointerEvent(folly::dynamic&& payload);
3296-
public const std::optional<std::vector<facebook::react::Tag>>& getHitPathForEventListener() const;
3297-
}
3298-
32993277
struct facebook::react::EventPayload {
33003278
public EventPayload() = default;
33013279
public EventPayload(const facebook::react::EventPayload&) = default;

‎scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api‎

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,6 @@ facebook::react::SharedColor facebook::react::colorFromRGBA(uint8_t r, uint8_t g
520520
facebook::react::SharedColor facebook::react::parsePlatformColor(const facebook::react::ContextContainer& contextContainer, int32_t surfaceId, const facebook::react::RawValue& value);
521521
facebook::react::SharedColor facebook::react::whiteColor();
522522
facebook::react::Size facebook::react::yogaMeassureToSize(int64_t value);
523-
facebook::react::SurfaceId facebook::react::getNextRootViewTag() noexcept;
524523
facebook::react::TurboModuleMethodValueKind facebook::react::getTurboModuleMethodValueKind(facebook::jsi::Runtime& rt, const facebook::jsi::Value* value);
525524
facebook::react::ValueUnit facebook::react::toValueUnit(const facebook::react::RawValue& value);
526525
facebook::yoga::FloatOptional facebook::react::convertAspectRatio(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value);
@@ -530,8 +529,6 @@ float facebook::react::blueFromHostPlatformColor(facebook::react::Color color);
530529
float facebook::react::greenFromHostPlatformColor(facebook::react::Color color);
531530
float facebook::react::redFromHostPlatformColor(facebook::react::Color color);
532531
float facebook::react::yogaFloatFromFloat(facebook::react::Float value);
533-
folly::dynamic facebook::react::diffDynamicProps(const folly::dynamic& oldProps, const folly::dynamic& newProps);
534-
folly::dynamic facebook::react::mergeDynamicProps(const folly::dynamic& source, const folly::dynamic& patch, facebook::react::NullValueStrategy nullValueStrategy);
535532
folly::dynamic facebook::react::toDynamic(const YGValue& dimension);
536533
folly::dynamic facebook::react::toDynamic(const facebook::react::BackgroundImage& backgroundImage);
537534
folly::dynamic facebook::react::toDynamic(const facebook::react::BoxShadow& boxShadow);
@@ -2920,11 +2917,6 @@ enum facebook::react::ModalHostViewSupportedOrientations : facebook::react::Moda
29202917
PortraitUpsideDown,
29212918
}
29222919

2923-
enum facebook::react::NullValueStrategy {
2924-
Ignore,
2925-
Override,
2926-
}
2927-
29282920
enum facebook::react::OutlineStyle : uint8_t {
29292921
Dashed,
29302922
Dotted,
@@ -3282,20 +3274,6 @@ struct facebook::react::DropShadowParams {
32823274
public folly::dynamic toDynamic() const;
32833275
}
32843276

3285-
struct facebook::react::DynamicEventPayload : public facebook::react::EventPayload {
3286-
protected folly::dynamic payload_;
3287-
public DynamicEventPayload(folly::dynamic&& payload);
3288-
public static facebook::react::SharedEventPayload create(folly::dynamic&& payload);
3289-
public virtual facebook::jsi::Value asJSIValue(facebook::jsi::Runtime& runtime) const override;
3290-
public virtual facebook::react::EventPayloadType getType() const override;
3291-
public virtual std::optional<double> extractValue(const std::vector<std::string>&) const override;
3292-
}
3293-
3294-
struct facebook::react::DynamicPointerEvent : public facebook::react::DynamicEventPayload {
3295-
public DynamicPointerEvent(folly::dynamic&& payload);
3296-
public const std::optional<std::vector<facebook::react::Tag>>& getHitPathForEventListener() const;
3297-
}
3298-
32993277
struct facebook::react::EventPayload {
33003278
public EventPayload() = default;
33013279
public EventPayload(const facebook::react::EventPayload&) = default;

‎scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api‎

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -3297,7 +3297,6 @@ facebook::react::SharedColor facebook::react::colorFromRGBA(uint8_t r, uint8_t g
32973297
facebook::react::SharedColor facebook::react::parsePlatformColor(const facebook::react::ContextContainer& contextContainer, int32_t surfaceId, const facebook::react::RawValue& value);
32983298
facebook::react::SharedColor facebook::react::whiteColor();
32993299
facebook::react::Size facebook::react::yogaMeassureToSize(int64_t value);
3300-
facebook::react::SurfaceId facebook::react::getNextRootViewTag() noexcept;
33013300
facebook::react::TurboModuleMethodValueKind facebook::react::getTurboModuleMethodValueKind(facebook::jsi::Runtime& rt, const facebook::jsi::Value* value);
33023301
facebook::react::ValueUnit facebook::react::toValueUnit(const facebook::react::RawValue& value);
33033302
facebook::yoga::FloatOptional facebook::react::convertAspectRatio(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value);
@@ -3308,8 +3307,6 @@ float facebook::react::greenFromHostPlatformColor(facebook::react::Color color);
33083307
float facebook::react::redFromHostPlatformColor(facebook::react::Color color);
33093308
float facebook::react::yogaFloatFromFloat(facebook::react::Float value);
33103309
folly::dynamic facebook::react::convertIdToFollyDynamic(id json);
3311-
folly::dynamic facebook::react::diffDynamicProps(const folly::dynamic& oldProps, const folly::dynamic& newProps);
3312-
folly::dynamic facebook::react::mergeDynamicProps(const folly::dynamic& source, const folly::dynamic& patch, facebook::react::NullValueStrategy nullValueStrategy);
33133310
id facebook::react::convertFollyDynamicToId(const folly::dynamic& dyn);
33143311
int facebook::react::toInt(const facebook::react::DisplayType& displayType);
33153312
int facebook::react::toInt(const facebook::react::LayoutDirection& layoutDirection);
@@ -5109,11 +5106,6 @@ enum facebook::react::ModalHostViewSupportedOrientations : facebook::react::Moda
51095106
PortraitUpsideDown,
51105107
}
51115108

5112-
enum facebook::react::NullValueStrategy {
5113-
Ignore,
5114-
Override,
5115-
}
5116-
51175109
enum facebook::react::OutlineStyle : uint8_t {
51185110
Dashed,
51195111
Dotted,
@@ -5445,20 +5437,6 @@ struct facebook::react::DynamicColor {
54455437
public int32_t lightColor;
54465438
}
54475439

5448-
struct facebook::react::DynamicEventPayload : public facebook::react::EventPayload {
5449-
protected folly::dynamic payload_;
5450-
public DynamicEventPayload(folly::dynamic&& payload);
5451-
public static facebook::react::SharedEventPayload create(folly::dynamic&& payload);
5452-
public virtual facebook::jsi::Value asJSIValue(facebook::jsi::Runtime& runtime) const override;
5453-
public virtual facebook::react::EventPayloadType getType() const override;
5454-
public virtual std::optional<double> extractValue(const std::vector<std::string>& path) const override;
5455-
}
5456-
5457-
struct facebook::react::DynamicPointerEvent : public facebook::react::DynamicEventPayload {
5458-
public DynamicPointerEvent(folly::dynamic&& payload);
5459-
public const std::optional<std::vector<facebook::react::Tag>>& getHitPathForEventListener() const;
5460-
}
5461-
54625440
struct facebook::react::EventPayload {
54635441
public EventPayload() = default;
54645442
public EventPayload(const facebook::react::EventPayload&) = default;

‎scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api‎

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -3289,7 +3289,6 @@ facebook::react::SharedColor facebook::react::colorFromRGBA(uint8_t r, uint8_t g
32893289
facebook::react::SharedColor facebook::react::parsePlatformColor(const facebook::react::ContextContainer& contextContainer, int32_t surfaceId, const facebook::react::RawValue& value);
32903290
facebook::react::SharedColor facebook::react::whiteColor();
32913291
facebook::react::Size facebook::react::yogaMeassureToSize(int64_t value);
3292-
facebook::react::SurfaceId facebook::react::getNextRootViewTag() noexcept;
32933292
facebook::react::TurboModuleMethodValueKind facebook::react::getTurboModuleMethodValueKind(facebook::jsi::Runtime& rt, const facebook::jsi::Value* value);
32943293
facebook::react::ValueUnit facebook::react::toValueUnit(const facebook::react::RawValue& value);
32953294
facebook::yoga::FloatOptional facebook::react::convertAspectRatio(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value);
@@ -3300,8 +3299,6 @@ float facebook::react::greenFromHostPlatformColor(facebook::react::Color color);
33003299
float facebook::react::redFromHostPlatformColor(facebook::react::Color color);
33013300
float facebook::react::yogaFloatFromFloat(facebook::react::Float value);
33023301
folly::dynamic facebook::react::convertIdToFollyDynamic(id json);
3303-
folly::dynamic facebook::react::diffDynamicProps(const folly::dynamic& oldProps, const folly::dynamic& newProps);
3304-
folly::dynamic facebook::react::mergeDynamicProps(const folly::dynamic& source, const folly::dynamic& patch, facebook::react::NullValueStrategy nullValueStrategy);
33053302
id facebook::react::convertFollyDynamicToId(const folly::dynamic& dyn);
33063303
int facebook::react::toInt(const facebook::react::DisplayType& displayType);
33073304
int facebook::react::toInt(const facebook::react::LayoutDirection& layoutDirection);
@@ -5094,11 +5091,6 @@ enum facebook::react::ModalHostViewSupportedOrientations : facebook::react::Moda
50945091
PortraitUpsideDown,
50955092
}
50965093

5097-
enum facebook::react::NullValueStrategy {
5098-
Ignore,
5099-
Override,
5100-
}
5101-
51025094
enum facebook::react::OutlineStyle : uint8_t {
51035095
Dashed,
51045096
Dotted,
@@ -5430,20 +5422,6 @@ struct facebook::react::DynamicColor {
54305422
public int32_t lightColor;
54315423
}
54325424

5433-
struct facebook::react::DynamicEventPayload : public facebook::react::EventPayload {
5434-
protected folly::dynamic payload_;
5435-
public DynamicEventPayload(folly::dynamic&& payload);
5436-
public static facebook::react::SharedEventPayload create(folly::dynamic&& payload);
5437-
public virtual facebook::jsi::Value asJSIValue(facebook::jsi::Runtime& runtime) const override;
5438-
public virtual facebook::react::EventPayloadType getType() const override;
5439-
public virtual std::optional<double> extractValue(const std::vector<std::string>& path) const override;
5440-
}
5441-
5442-
struct facebook::react::DynamicPointerEvent : public facebook::react::DynamicEventPayload {
5443-
public DynamicPointerEvent(folly::dynamic&& payload);
5444-
public const std::optional<std::vector<facebook::react::Tag>>& getHitPathForEventListener() const;
5445-
}
5446-
54475425
struct facebook::react::EventPayload {
54485426
public EventPayload() = default;
54495427
public EventPayload(const facebook::react::EventPayload&) = default;

0 commit comments

Comments
 (0)