Commit 0ab0acf
[Backport] Security bug 431668129
Manual cherry-pick of patch originally reviewed on
https://chromium-review.googlesource.com/c/chromium/src/+/6757109:
Check for existence of this in `DialogDelegate::RunCloseCallback`
Similarly to https://crrev.com/c/6370014 for the repeated callback
variant, widget can get destroyed after running OnceClosure. Since in
case of OnceClosure `already_started_close_` is just assigned to true,
return it directly after running the callback instead of returning
possibly destroyed member at the end.
Fixed: 431668129
Change-Id: I6848d351fb3776a82568300d148b4b9189f52078
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6757109
Commit-Queue: Rafał Godlewski <[email protected]>
Reviewed-by: Keren Zhu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1487815}
Reviewed-on: https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/665028
Reviewed-by: Allan Sandfeld Jensen <[email protected]>1 parent 9019361 commit 0ab0acf
1 file changed
+3
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
| 204 | + | |
204 | 205 | | |
205 | 206 | | |
206 | 207 | | |
| 208 | + | |
207 | 209 | | |
208 | 210 | | |
209 | | - | |
| 211 | + | |
210 | 212 | | |
211 | 213 | | |
212 | 214 | | |
| |||
0 commit comments