Actually error on --no-local-parial-types in parallel mode

Author: ilevkivskyi

mypy/build.py

@@ -898,6 +898,7 @@ def __init__(
             self.errors,
             self.plugin,
             self.import_map,
+            parallel_worker,
         )
         self.all_types: dict[Expression, Type] = {}  # Enabled by export_types
         self.indirection_detector = TypeIndirectionVisitor()

mypy/semanal.py

@@ -461,6 +461,7 @@ def __init__(
         errors: Errors,
         plugin: Plugin,
         import_map: dict[str, set[str]],
+        parallel_worker: bool,
     ) -> None:
         """Construct semantic analyzer.
 
@@ -494,6 +495,8 @@ def __init__(
         self.errors = errors
         self.modules = modules
         self.import_map = import_map
+        # True if this analysis is run in a parallel worker process.
+        self.parallel_worker = parallel_worker
         self.msg = MessageBuilder(errors, modules)
         self.missing_modules = missing_modules
         self.missing_names = [set()]
@@ -719,24 +722,26 @@ def refresh_partial(
                 self.accept(node)
         del self.patches
 
+    def ad_hoc_error(self, msg: str) -> None:
+        n = TempNode(AnyType(TypeOfAny.special_form))
+        n.line = 1
+        n.column = 0
+        n.end_line = 1
+        n.end_column = 0
+        self.fail(msg, n)
+
     def refresh_top_level(self, file_node: MypyFile) -> None:
         """Reanalyze a stale module top-level in fine-grained incremental mode."""
         if self.options.allow_redefinition and not self.options.local_partial_types:
-            n = TempNode(AnyType(TypeOfAny.special_form))
-            n.line = 1
-            n.column = 0
-            n.end_line = 1
-            n.end_column = 0
-            self.fail("--local-partial-types must be enabled if using --allow-redefinition", n)
+            self.ad_hoc_error(
+                "--local-partial-types must be enabled if using --allow-redefinition"
+            )
         if self.options.allow_redefinition and self.options.allow_redefinition_old:
-            n = TempNode(AnyType(TypeOfAny.special_form))
-            n.line = 1
-            n.column = 0
-            n.end_line = 1
-            n.end_column = 0
-            self.fail(
-                "--allow-redefinition-old and --allow-redefinition should not be used together", n
+            self.ad_hoc_error(
+                "--allow-redefinition-old and --allow-redefinition should not be used together"
             )
+        if not self.options.local_partial_types and self.parallel_worker:
+            self.ad_hoc_error("--local-partial-types must be enabled in parallel mode")
         self.recurse_into_functions = False
         self.add_implicit_module_attrs(file_node)
         for d in file_node.defs:

test-data/unit/check-bound.test

@@ -46,7 +46,7 @@ z = G(B())
 
 
 [case testBoundVoid]
-# flags: --no-strict-optional --no-local-partial-types
+# flags: --no-strict-optional
 from typing import TypeVar, Generic
 T = TypeVar('T', bound=int)
 class C(Generic[T]):
@@ -75,7 +75,7 @@ z: C
 
 
 [case testBoundHigherOrderWithVoid]
-# flags: --no-strict-optional --no-local-partial-types
+# flags: --no-strict-optional
 from typing import TypeVar, Callable
 class A: pass
 T = TypeVar('T', bound=A)

test-data/unit/check-columns.test

@@ -209,7 +209,6 @@ y: Dict[int, int] = {
 [builtins fixtures/dict.pyi]
 
 [case testColumnCannotDetermineType]
-# flags: --no-local-partial-types
 (x)  # E:2: Cannot determine type of "x"  # E:2: Name "x" is used before definition
 x = None
 

test-data/unit/check-custom-plugin.test

@@ -1007,7 +1007,7 @@ reveal_type(Cls.attr) # N: Revealed type is "builtins.int"
 plugins=<ROOT>/test-data/unit/plugins/class_attr_hook.py
 
 [case testClassAttrPluginPartialType]
-# flags: --config-file tmp/mypy.ini --no-local-partial-types
+# flags: --config-file tmp/mypy.ini
 
 class Cls:
     attr = None

test-data/unit/check-errorcodes.test

@@ -981,7 +981,7 @@ Foo = TypedDict("Bar", {})  # E: First argument "Bar" to TypedDict() does not ma
 [typing fixtures/typing-typeddict.pyi]
 
 [case testTruthyBool]
-# flags: --enable-error-code truthy-bool --no-local-partial-types
+# flags: --enable-error-code truthy-bool
 from typing import List, Union, Any
 
 class Foo:

test-data/unit/check-functions.test

@@ -2664,7 +2664,7 @@ reveal_type(bar(None))  # N: Revealed type is "None"
 [out]
 
 [case testNoComplainInferredNone]
-# flags: --no-strict-optional --no-local-partial-types
+# flags: --no-strict-optional
 from typing import TypeVar, Optional
 T = TypeVar('T')
 def X(val: T) -> T: ...

test-data/unit/check-incremental.test

@@ -6639,7 +6639,7 @@ class C: ...
 [out2]
 [out3]
 
-[case testNoCrashOnPartialLambdaInference]
+[case testNoCrashOnPartialLambdaInference_no_parallel]
 # flags: --no-local-partial-types
 import m
 [file m.py]
@@ -6666,6 +6666,37 @@ reveal_type(xs)
 [out2]
 tmp/m.py:9: note: Revealed type is "builtins.list[builtins.int]"
 
+[case testNoCrashOnPartialLambdaInference_parallel_only]
+# flags: --local-partial-types
+import m
+[file m.py]
+from typing import TypeVar, Callable
+
+V = TypeVar("V")
+def apply(val: V, func: Callable[[V], None]) -> None:
+    return func(val)
+
+xs = []
+apply(0, lambda a: xs.append(a))
+[file m.py.2]
+from typing import TypeVar, Callable
+
+V = TypeVar("V")
+def apply(val: V, func: Callable[[V], None]) -> None:
+    return func(val)
+
+xs = []
+apply(0, lambda a: xs.append(a))
+reveal_type(xs)
+[builtins fixtures/list.pyi]
+[out]
+tmp/m.py:7: error: Need type annotation for "xs" (hint: "xs: list[<type>] = ...")
+tmp/m.py:8: error: Cannot determine type of "xs"
+[out2]
+tmp/m.py:7: error: Need type annotation for "xs" (hint: "xs: list[<type>] = ...")
+tmp/m.py:8: error: Cannot determine type of "xs"
+tmp/m.py:9: note: Revealed type is "builtins.list[Any]"
+
 [case testTypingSelfCoarse]
 import m
 [file lib.py]

test-data/unit/check-inference.test

@@ -1925,7 +1925,6 @@ reveal_type(C().a)  # N: Revealed type is "builtins.dict[Any, Any]"
 [builtins fixtures/dict.pyi]
 
 [case testInferAttributeInitializedToNoneAndAssignedClassBody]
-# flags: --no-local-partial-types
 class C:
     a = None
     def __init__(self) -> None:
@@ -2099,7 +2098,6 @@ x = 1
 [out]
 
 [case testPartiallyInitializedVariableDoesNotEscapeScope2]
-# flags: --no-local-partial-types
 x = None
 def f() -> None:
     x = None
@@ -2127,22 +2125,6 @@ main:6: error: Incompatible types in assignment (expression has type "int", vari
 main:7: error: "None" not callable
 
 [case testGlobalInitializedToNoneSetFromFunction]
-# flags: --no-local-partial-types
-a = None
-def f() -> None:
-    global a
-    a = 42
-    reveal_type(a)  # N: Revealed type is "builtins.int"
-reveal_type(a)  # N: Revealed type is "builtins.int | None"
-
-b = None
-def unchecked():
-    global b
-    b = 42
-reveal_type(b)  # N: Revealed type is "Any | None"
-
-[case testGlobalInitializedToNoneSetFromFunctionLocalPartialTypes]
-# flags: --local-partial-types
 a = None
 def f() -> None:
     global a
@@ -2157,23 +2139,6 @@ def unchecked():
 reveal_type(b)  # N: Revealed type is "Any | None"
 
 [case testGlobalInitializedToNoneSetFromMethod]
-# flags: --no-local-partial-types
-a = None
-class C:
-    def m(self) -> None:
-        global a
-        a = 42
-reveal_type(a)  # N: Revealed type is "builtins.int | None"
-
-b = None
-class CC:
-    def unchecked(self):
-        global b
-        b = 42
-reveal_type(b)  # N: Revealed type is "Any | None"
-
-[case testGlobalInitializedToNoneSetFromMethodLocalPartialTypes]
-# flags: --local-partial-types
 a = None
 class C:
     def m(self) -> None:
@@ -2189,7 +2154,6 @@ class CC:
 reveal_type(b)  # N: Revealed type is "Any | None"
 
 [case testPartialTypeErrorSpecialCase1]
-# flags: --no-local-partial-types
 # This used to crash.
 class A:
     x = None
@@ -2208,7 +2172,6 @@ class A:
 [builtins fixtures/for.pyi]
 
 [case testPartialTypeErrorSpecialCase3]
-# flags: --no-local-partial-types
 class A:
     x = None
     def f(self) -> None:
@@ -2561,7 +2524,6 @@ main:4: error: Unsupported target for indexed assignment ("type[C[T]]")
 main:4: error: Invalid type: try using Literal[0] instead?
 
 [case testNoCrashOnPartialMember]
-# flags: --no-local-partial-types
 class C:
     x = None
     def __init__(self) -> None:
@@ -2580,7 +2542,6 @@ reveal_type(x) # N: Revealed type is "builtins.str"
 [builtins fixtures/tuple.pyi]
 
 [case testNoCrashOnPartialVariable2]
-# flags: --no-local-partial-types
 from typing import Tuple, TypeVar
 T = TypeVar('T', bound=str)
 
@@ -4364,7 +4325,7 @@ def f() -> None:
     global x
     x
 
-[case testPerFileNoLocalPartialTypesForcesSinglePhase]
+[case testPerFileNoLocalPartialTypesForcesSinglePhase_no_parallel]
 # mypy: no-local-partial-types
 
 x = []
@@ -4374,3 +4335,15 @@ def func() -> None:
 
 reveal_type(x)  # N: Revealed type is "builtins.list[builtins.int]"
 [builtins fixtures/list.pyi]
+
+[case testPerFileNoLocalPartialTypesForcesSinglePhase_parallel_only]
+# mypy: no-local-partial-types
+
+x = []
+
+def func() -> None:
+    x.append(1)
+[builtins fixtures/list.pyi]
+[out]
+main:1: error: --local-partial-types must be enabled in parallel mode
+main:3: error: Need type annotation for "x" (hint: "x: list[<type>] = ...")

test-data/unit/check-protocols.test

@@ -2920,7 +2920,6 @@ hs(None)
 
 
 [case testPartialTypeProtocol]
-# flags: --no-local-partial-types
 from typing import Protocol
 
 class Flapper(Protocol):
@@ -2941,25 +2940,7 @@ class Gleemer:
 
 
 [case testPartialTypeProtocolHashable]
-# flags: --no-strict-optional --no-local-partial-types
-from typing import Protocol
-
-class Hashable(Protocol):
-    def __hash__(self) -> int: ...
-
-class ObjectHashable:
-    def __hash__(self) -> int: ...
-
-class DataArray(ObjectHashable):
-    __hash__ = None
-
-    def f(self, x: Hashable) -> None:
-        reveal_type([self, x])  # N: Revealed type is "builtins.list[builtins.object]"
-[builtins fixtures/tuple.pyi]
-
-
-[case testPartialTypeProtocolHashableLocalPartialTypes]
-# flags: --no-strict-optional --local-partial-types
+# flags: --no-strict-optional
 from typing import Protocol
 
 class Hashable(Protocol):
@@ -2977,7 +2958,7 @@ class DataArray(ObjectHashable):
 
 
 [case testPartialAttributeNoneType]
-# flags: --no-strict-optional --no-local-partial-types
+# flags: --no-strict-optional
 from typing import Optional, Protocol, runtime_checkable
 
 @runtime_checkable
@@ -2995,7 +2976,6 @@ class MyClass:
 
 
 [case testPartialAttributeNoneTypeStrictOptional]
-# flags: --no-local-partial-types
 from typing import Optional, Protocol, runtime_checkable
 
 @runtime_checkable