Downloading fails if filename contains special characters

[Stattek]

Metadata
Version: 5.0.0
OS: Arch Linux
Shell: bash
Anime: Any containing special characters such as :

Describe the bug
When downloading any file, it seems that the filename to write is not sanitized properly, which can lead to it being rejected by ffmpeg.

The example below shows it rejecting files with : but there may be more possible.

Steps To Reproduce

1. Run ani-cli --download
2. Search for show (this example shows gup)
3. Choose any of the options containing a : character.

Expected behavior
Should download properly.

Actual behavior
ffmpeg command fails to download because it seems to reject filenames with special characters.

$ ani-cli --download
Checking dependencies...
anidb.app links fetched
[out#0/mp4 @ 0x55c272c060c0] Error opening output ./Girls & Panzer: Saishuushou Part 3 Episode 1.mp4: Invalid argument
Error opening output file ./Girls & Panzer: Saishuushou Part 3 Episode 1.mp4.
Error opening output files: Invalid argument

[port19x]

What filesystem do you run? Works on mac os.

[Stattek]

What filesystem do you run? Works on mac os.

I am using a mounted (via gvfs) Samba file share that's hosted on a pi. The actual filesystem that is used on that drive is ext4.

Trying to download the same file on my other ext4 drives works or mounting the Samba share via cifs rather than gvfs.

I wonder if it was rejecting : because it's an illegal character for files on Windows, when I have it mounted via gvfs. Perhaps sanitizing filenames to exclude illegal characters for Windows could fix it.

The following command seems to be the issue (running with set -x in bash)

+ ffmpeg -extension_picky 0 -loglevel error -stats -i https://hls.anidb.app/stream/Ffi6037ZJwdbCINMlnPqlXYPN0lG8KzD58ZENqTHO0aI76_029bNQYJZdy3edmte/index-f1-v1-a1.m3u8 -c copy './Girls & Panzer: Saishuushou Part 3 Episode 1.mp4'
[out#0/mp4 @ 0x55d32146d380] Error opening output ./Girls & Panzer: Saishuushou Part 3 Episode 1.mp4: Invalid argument
Error opening output file ./Girls & Panzer: Saishuushou Part 3 Episode 1.mp4.
Error opening output files: Invalid argument

I can download the file just fine if I modify the ffmpeg command to remove the :

[Noddy81]

I have the same issue.

Os android 13 (hyperos)

Ani-cli-1853
Termux latest version

~ $ ani-cli -d kamui: behind -e 1
anidb.app links fetched
[generic] Extracting URL: https://hls.anidb.app/stream/WH700AieW-RmmHekWKrwDVzygEAmQgkiJEvabkTlpJUvOOnl6fHSE_0FtXpcOOsV/index-f1-v1-a1.m3u8
[generic] index-f1-v1-a1: Downloading webpage
[generic] index-f1-v1-a1: Downloading m3u8 information
[generic] index-f1-v1-a1: Checking m3u8 live status
[info] index-f1-v1-a1: Downloading 1 format(s): 0
[hlsnative] Downloading m3u8 manifest
WARNING: Live HLS streams are not supported by the native downloader. If this is a livestream, please add "--downloader ffmpeg --hls-use-mpegts" to your command
[hlsnative] Total fragments: 219
[download] Destination: ./KAMUI: He's Behind You Episode 1.mp4
ERROR: Unable to download video: [Errno 1] Operation not permitted: "./KAMUI: He's Behind You Episode 1.mp4.ytdl"
[out#0/mp4 @ 0xb400006f43815c00] Error opening output ./KAMUI: He's Behind You Episode 1.mp4: Operation not permitted
Error opening output file ./KAMUI: He's Behind You Episode 1.mp4.
Error opening output files: Operation not permitted

Also had the issue with ? in the show name.

Manually downloading the link after saving it to the file YT-DL.txt

yt-dlp -a YT-DL.txt

[generic] Extracting URL: https://hls.anidb.app/stream/WH700AieW-RmmHekWKrwDVzygEAmQgkiJEvabkTlpJUvOOnl6fHSE_0FtXpcOOsV/index-f1-v1-a1.m3u8
[generic] index-f1-v1-a1: Downloading webpage
[generic] index-f1-v1-a1: Downloading m3u8 information
[generic] index-f1-v1-a1: Checking m3u8 live status
[info] index-f1-v1-a1: Downloading 1 format(s): 0
[hlsnative] Downloading m3u8 manifest
WARNING: Live HLS streams are not supported by the native downloader. If this is a livestream, please add "--downloader ffmpeg --hls-use-mpegts" to your command
[hlsnative] Total fragments: 219
[download] Destination: index-f1-v1-a1 [index-f1-v1-a1].mp4
[download] 24.0% of ~ 336.27MiB at 3.95MiB/s ETA 01:03 (frag 53/219)

Issue is that the naming of the save file permits forbidden characters for file names.

[Noddy81]

Line 300 workaround i figured out:

#PLAYING

shellcheck disable=SC2086

$1 = video link, $2 = video name, $3 = extra flags

download() {
command -v "yt-dlp" >/dev/null && yt-dlp "$1" --no-skip-unavailable-fragments --fragment-retries infinite -N 16 -o "$download_dir/$( echo "$2" | tr -d ":!?").mp4" $3 && return 0
ffmpeg -extension_picky 0 -loglevel error -stats -i "$1" -c copy "$download_dir/$( echo "$2" | tr -d ":!?").mp4" $3
}