From 3240a7b20bde2d512555ed1c2fe39f13259a6b20 Mon Sep 17 00:00:00 2001 From: nstarman Date: Sun, 15 Nov 2026 09:17:36 -0800 Subject: [PATCH 1/2] refactor: route the remaining direct Tracer checks through not_jax_tracer multinomial and LocScaleReparam checked isinstance(x, Tracer) directly. Use not_jax_tracer like the other callers, so a traced value inside an array-like pytree is treated the same way everywhere. Co-Authored-By: Claude Opus 5.5 --- numpyro/distributions/util.py | 3 +-- numpyro/infer/reparam.py | 7 ++++--- test/infer/test_reparam.py | 11 ++++++++++- test/test_distributions_util.py | 11 +++++++++++ 4 files changed, 26 insertions(+), 6 deletions(-) diff --git a/numpyro/distributions/util.py b/numpyro/distributions/util.py index 36d2b2938..956a5cd3f 100644 --- a/numpyro/distributions/util.py +++ b/numpyro/distributions/util.py @@ -13,7 +13,6 @@ import jax from jax import Array, jit, lax, random, vmap -from jax.core import Tracer import jax.numpy as jnp from jax.scipy.linalg import solve_triangular from jax.scipy.special import digamma @@ -298,7 +297,7 @@ def _multinomial(key, p, n, n_max, shape=()): def multinomial(key, p, n, shape=(), total_count_max=None): if total_count_max is None: - if isinstance(n, Tracer): + if not not_jax_tracer(n): raise ValueError( "Please specify total_count_max in Multinomial distribution." ) diff --git a/numpyro/infer/reparam.py b/numpyro/infer/reparam.py index 783318ed1..3e6c1a3e8 100644 --- a/numpyro/infer/reparam.py +++ b/numpyro/infer/reparam.py @@ -7,7 +7,6 @@ import numpy as np -import jax import jax.numpy as jnp import numpyro @@ -91,8 +90,10 @@ class LocScaleReparam(Reparam): """ def __init__(self, centered=None, shape_params=()): - assert centered is None or isinstance( - centered, (int, float, np.generic, np.ndarray, jnp.ndarray, jax.core.Tracer) + assert ( + centered is None + or isinstance(centered, (int, float, np.generic, np.ndarray, jnp.ndarray)) + or not not_jax_tracer(centered) ) assert isinstance(shape_params, (tuple, list)) assert all(isinstance(name, str) for name in shape_params) diff --git a/test/infer/test_reparam.py b/test/infer/test_reparam.py index 9d2854684..3f3fad6fe 100644 --- a/test/infer/test_reparam.py +++ b/test/infer/test_reparam.py @@ -7,7 +7,7 @@ from numpy.testing import assert_allclose import pytest -from jax import jacobian, lax, random +from jax import jacobian, jit, lax, random import jax.numpy as jnp import numpyro @@ -591,3 +591,12 @@ def run(config): return mcmc.get_samples()["x"].mean(0) assert_allclose(run({"x": reparam}), run({}), atol=0.15) + + +def test_loc_scale_traced_centered(): + @jit + def f(centered): + reparam = LocScaleReparam(centered) + return reparam.centered + + assert f(jnp.array(0.5)) == 0.5 diff --git a/test/test_distributions_util.py b/test/test_distributions_util.py index 9616b9645..b37bfceb6 100644 --- a/test/test_distributions_util.py +++ b/test/test_distributions_util.py @@ -473,3 +473,14 @@ def test_promote_shapes_array_like(): assert y.shape == (1,) assert x.shape == (3,) assert_allclose(y.todense(), jnp.array([2.0])) + + +def test_multinomial_traced_n_requires_total_count_max(): + p = jnp.array([0.2, 0.3, 0.5]) + + @jax.jit + def f(n): + return multinomial(random.key(0), p, n) + + with pytest.raises(ValueError, match="total_count_max"): + f(jnp.array(10)) From 9f60f2c3c4b2a1420f4cf223d545cc8e873be2a3 Mon Sep 17 00:00:00 2001 From: nstarman Date: Tue, 17 Nov 2026 00:09:14 -0800 Subject: [PATCH 2/2] refactor(infer): make the LocScaleReparam centered check a plain type check Tracers are jax.Array instances, so the isinstance check already accepts them; routing it through not_jax_tracer would also let containers holding a tracer through, as noted in review. Co-Authored-By: Claude Opus 5.5 --- numpyro/infer/reparam.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/numpyro/infer/reparam.py b/numpyro/infer/reparam.py index 3e6c1a3e8..d1f69ed43 100644 --- a/numpyro/infer/reparam.py +++ b/numpyro/infer/reparam.py @@ -90,10 +90,8 @@ class LocScaleReparam(Reparam): """ def __init__(self, centered=None, shape_params=()): - assert ( - centered is None - or isinstance(centered, (int, float, np.generic, np.ndarray, jnp.ndarray)) - or not not_jax_tracer(centered) + assert centered is None or isinstance( + centered, (int, float, np.generic, np.ndarray, jnp.ndarray) ) assert isinstance(shape_params, (tuple, list)) assert all(isinstance(name, str) for name in shape_params)