fix(ui): show Top Failed Requirements for compliances without section hierarchy #9471
+205
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hierarchy For compliances like RBI that have a flat structure (requirements directly in framework without categories/sections), the Top Failed Sections chart was showing empty because the logic only iterated over framework.categories. This fix: - Detects flat structure compliances (framework.requirements without categories) - Shows 'Top Failed Requirements' for flat structures - Keeps 'Top Failed Sections' for hierarchical structures (like ENS) - Updates getTopFailedSections to return TopFailedResult with type metadata - Adds dynamic title to TopFailedSectionsCard component
Contributor
|
✅ All necessary |
13 tasks
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Contributor
🔒 Container Security ScanImage: ✅ No Vulnerabilities DetectedThe container image passed all security checks. No known CVEs were found.📋 Resources:
|
- Add optional requirements property to Framework interface for flat structures - Replace union type with const-based pattern for TopFailedDataType - Remove all 'as any' casts from commons.tsx and mitre.tsx - Extract helper functions (buildTopFailedResult, hasFlatStructure, incrementFailedCount) for DRY - Type Maps properly with explicit generic parameters - Add proper return types to findOrCreateCategory and findOrCreateControl - Replace any[] with unknown[] in ENSAttributesMetadata - Fix React import to use named imports (createElement, ReactNode) - Update pre-commit hook to allow var() in chart components
Alan-TheGentleman
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR extracts the UI fix from PR #9470 to show Top Failed Requirements for compliances that have a flat structure (like RBI) without the compliance JSON changes.
Fix for compliances that don't have section hierarchy showing empty "Top Failed Sections" chart.
[Before]
[After]
Description
For compliances like RBI that have a flat structure (requirements directly in framework without categories/sections), the Top Failed Sections chart was showing empty because the logic only iterated over framework.categories.
This fix:
Steps to review
Checklist
UI
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.