CI update macOS 14 to 26 #42299
Draft
CI update macOS 14 to 26 #42299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates macOS GitHub Actions runners from version 14 to version 26 and adds sudo to test execution to resolve multicast traffic permission issues on newer macOS versions.
Key changes:
- Updates all macOS runner references from
macos-14tomacos-26across CI workflows - Adds
sudoprefix to test execution intests.yamlto enable multicast traffic for Group-related tests - Addresses multicast permission restrictions for the
runneruser on newer macOS versions
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/tests.yaml |
Updates runner version to macos-26 in test matrices and adds sudo to test execution to fix multicast traffic issues |
.github/workflows/fuzzing-build.yaml |
Updates Darwin fuzzing build runner to macos-26 |
.github/workflows/example-tv-casting-darwin.yaml |
Updates TV casting bridge example runner to macos-26 |
.github/workflows/darwin.yaml |
Updates Darwin build and test runner matrices to macos-26 |
.github/workflows/darwin-tests.yaml |
Updates Darwin test runner to macos-26 |
.github/workflows/build.yaml |
Updates Darwin build runner to macos-26 |
|
PR #42299: Size comparison from d85e161 to 026117d Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #42299: Size comparison from d85e161 to d078846 Increases above 0.2%:
Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
.github/workflows/tests.yaml
Outdated
Comment on lines
565
to
567
| # accessories.py doesn't use SO_REUSEADDR, so when the first test suite (running as root via sudo) | ||
| # closes the XML-RPC server on port 9000, the socket enters TIME_WAIT state owned by root. | ||
| # The subsequent test step (running as the 'runner' user) cannot bind to the same port until TIME_WAIT expires. |
Contributor
There was a problem hiding this comment.
Is that because it's a different user or because it's root vs not?
If the latter, we could change the order of the steps.
If the former, we could run "purposeful failure tests" under sudo as well.
Contributor
Author
There was a problem hiding this comment.
It's looking like running purposeful failure tests under sudo is the way to go.
|
PR #42299: Size comparison from d85e161 to 49c18b8 Increases above 0.2%:
Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
|
PR #42299: Size comparison from d85e161 to b697c20 Increases above 0.2%:
Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
this allows multicast traffic so relevant tests can pass
kiel-apple
force-pushed
the
darwin-ci-macOS-26
branch
from
b697c20 to
45b86a7
Compare
|
PR #42299: Size comparison from efdf99d to 45b86a7 Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating CI to latest macOS.
On a previous branch, had to do some troubleshooting on some tests that involve Groups - they passed on macOS 26 locally, but not in GitHub Actions. Filed #41873 to investigate. Investigation revealed that on macOS 15 and macOS 26, multicast traffic was disallowed for the
runneruser where it was allowed on macOS 14. Usingsudo, multicast traffic is allowed.Related issues
#41873 should be fixed if this passes CI.
Testing
CI changes only.
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)