test: migrate write tests
#53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiospampinato
force-pushed
the
main
branch
4 times, most recently
from
34e0257 to
f8dc396
Compare
Collaborator
|
Should we align with prettier here, outputting an elapsed time too (if it's big enough?) and outputting the "(unchanged)" bit? 🤔 |
Collaborator
Author
|
I'm not sure. It's given per file so seems a bit unnecessary in that case, since each one is usually "0ms" individually |
Member
|
About
people are asking to remove it, I already mark this as accepted. |
Collaborator
Author
|
Ah awesome I think we are already all good then 👍 for that particular behaviour |
Member
|
|
Collaborator
Author
|
aha very good point! so we should drop the |
Copies the `write` tests from prettier. Notable differences: - Unchanged files are still listed in the output in prettier, but not here (e.g. `foo.js (unchanged)`) - Written files also log out the time taken in prettier (e.g. `foo.js 0ms`)
fabiospampinato
force-pushed
the
tests-write
branch
from
829d597 to
b12a67f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies the
writetests from prettier.Notable differences:
foo.js (unchanged))foo.js 0ms)