Issue when moving between screens with different brightness settings

[ghnp5]

The problem

First of all - THANK YOU for this fork! Besides it working on Linux, it also brings new features that the upstream actually refuses to implement :)

I have two monitors in my desktop. Although they're the exact same model, one is connected with HDMI and the other is connected with DisplayPort. And, I think that is the reason I actually need to have different Brightness options between both, for them to look similar.

Monitor 1:

Monitor 2:

When I move any app from one screen to the other screen, they look exactly the same as they were looking in the previous screen.

However, with Desktop Plus, it looks fine in whichever screen it's originally open on. But, when I move it to the other screen, the colors look messed up.

Monitor 1 -> Monitor 2 , the app will have a shadow all over.

Monitor 2 -> Monitor 1 , the app will be very bright.

Example:

Release version

3.5.6.6

Operating system and distro

Fedora 43 KDE Plasma, Wayland

Specific to GitHub Desktop Plus?

Yes

Log files

No new logs are generated in the file, when moving screens.

Additional context

This was not happening when I was using this Linux fork: https://github.com/shiftkey/desktop

[pol-rivero]

If I had to guess, I'd say this is a bug in Electron on Wayland. We'd need to find which Electron update caused this visual bug.

Try running npx electron@40, which should open an Electron demo window. Does it also look too bright in your other screen?

[ghnp5]

Thanks! Good suggestion.

So. When moving from Monitor 1 to Monitor 2, the app will have a shadow all over too, but after a few seconds it became fine. This actually also happens with Desktop Plus, sometimes.

When going from Monitor 2 to Monitor 1 (regardless if after "auto-fixing" like I said above, or if I originally opened in Monitor 2), the app looks fine when moving to Monitor 1.

Please note that I use other Electron apps, such as Signal and VSCode, and they don't have this problem.

[pol-rivero]

VSCode uses Electron 39 while we use Electron 40, so it seems like an Electron 40 bug, probably this one: electron/electron#49566

If that's the case, apparently it has been fixed in version 40.4.0, so I'll make sure to update the dependency.

[pol-rivero]

Please check if this issue is fixed in the latest release :)

[ghnp5]

Thanks! I'll check once it appears as an update in the Flathub. 🥳