Skip to content

Conversation

@jcechace
Copy link
Collaborator

@jcechace jcechace commented Dec 3, 2025

PBM-1663 Powered by Pull Request Badge

  • Display Profile when running pbm list
  • Display profile when running pbm status
  • Renamed storageName to profile in json output of pbm list and pbm status
  • Renamed strageName to profile in output of pbm describe-backup
  • Added storageType to output of pbm describe-backup

Type: b.Type,
SrcBackup: b.SrcBackup,
StoreName: b.Store.Name,
Profile: b.Store.Name,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boris-ilijic not 100% sure about this rename as it breaks backwards compatibility of the output. However we might want to unify on using "profile" instead of profile/storage (at least for user facing output)

Copy link
Member

@boris-ilijic boris-ilijic Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requirement is to rename output of describe-backup command. But, that's not that one. If you are referencing to that backwards compatibility, it's ok to change that imo.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know, this one is part of list/status output and the field is exposed only with json output format. That said, I think we should be consistent and use "profile" everywhere. Thus also changing it here.

The actual definition for this one is of course https://github.com/percona/percona-backup-mongodb/pull/1232/files#diff-af738542639de6b3986d91c7462ac67697ce30184538554a7764f771a4c1a942R1156

@jcechace jcechace force-pushed the PBM-1663-profile-ux-01 branch from 37f7db8 to 94f8807 Compare December 4, 2025 07:08
@jcechace jcechace changed the title PBM-1663: Include profile name when running pbm list or pbm status PBM-1663: Rename StorageName to Profile and always Include it Dec 4, 2025
@jcechace
Copy link
Collaborator Author

jcechace commented Dec 4, 2025

@boris-ilijic this one can be reviewed, adding --profile to list and status commands will be next (as a standalone PR).

Copy link
Member

@boris-ilijic boris-ilijic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

if ss.StoreName != "" {
t += ", *"
if ss.Profile != "" {
t += ", " + ss.Profile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the ticket:

we can display the profile name and shorten it if needed (e.g., limit it to 15 characters)

Currently we have:

Backups:
========
FS  /opt/backups/pbm
  Snapshots:
    2025-12-04T08:44:05Z 606.92MB <physical, this is one long named profile let's see how it looks like> success [restore_to_time: 2025-12-04T08:44:07]
    2025-12-04T08:40:54Z 605.09MB <physical, gcs> success [restore_to_time: 2025-12-04T08:40:57]
    2025-12-04T08:39:55Z 152.79KB <logical, s3> success [restore_to_time: 2025-12-04T08:39:59]
    2025-12-04T08:39:14Z 604.08MB <physical> success [restore_to_time: 2025-12-04T08:39:16]
    2025-12-04T08:38:44Z 94.38KB <logical> success [restore_to_time: 2025-12-04T08:38:48]

Maybe we can have like this to keep compact style:

  Snapshots:
    2025-12-04T08:44:05Z 606.92MB <physical, this is one...> success [restore_to_time: 2025-12-04T08:44:07]
    2025-12-04T08:40:54Z 605.09MB <physical, gcs> success [restore_to_time: 2025-12-04T08:40:57]

But I am not sure, what do you think?

Copy link
Collaborator Author

@jcechace jcechace Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add it, but I wouldn't expect this to be a common problem (nobody sensible is going to name their profile like that). If they do then it's not really breaking anything it will just make their output not so nice.

I actually decided to ignore that part on purpose and wanted to know if this is something you would find useful.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it as it is now then.

@jcechace jcechace merged commit 0ff01f7 into percona:dev Dec 4, 2025
24 checks passed
@jcechace jcechace deleted the PBM-1663-profile-ux-01 branch December 4, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants