-
Notifications
You must be signed in to change notification settings - Fork 111
PBM-1663: Rename StorageName to Profile and always Include it #1232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Type: b.Type, | ||
| SrcBackup: b.SrcBackup, | ||
| StoreName: b.Store.Name, | ||
| Profile: b.Store.Name, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boris-ilijic not 100% sure about this rename as it breaks backwards compatibility of the output. However we might want to unify on using "profile" instead of profile/storage (at least for user facing output)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requirement is to rename output of describe-backup command. But, that's not that one. If you are referencing to that backwards compatibility, it's ok to change that imo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know, this one is part of list/status output and the field is exposed only with json output format. That said, I think we should be consistent and use "profile" everywhere. Thus also changing it here.
The actual definition for this one is of course https://github.com/percona/percona-backup-mongodb/pull/1232/files#diff-af738542639de6b3986d91c7462ac67697ce30184538554a7764f771a4c1a942R1156
37f7db8 to
94f8807
Compare
|
@boris-ilijic this one can be reviewed, adding |
boris-ilijic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| if ss.StoreName != "" { | ||
| t += ", *" | ||
| if ss.Profile != "" { | ||
| t += ", " + ss.Profile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the ticket:
we can display the profile name and shorten it if needed (e.g., limit it to 15 characters)
Currently we have:
Backups:
========
FS /opt/backups/pbm
Snapshots:
2025-12-04T08:44:05Z 606.92MB <physical, this is one long named profile let's see how it looks like> success [restore_to_time: 2025-12-04T08:44:07]
2025-12-04T08:40:54Z 605.09MB <physical, gcs> success [restore_to_time: 2025-12-04T08:40:57]
2025-12-04T08:39:55Z 152.79KB <logical, s3> success [restore_to_time: 2025-12-04T08:39:59]
2025-12-04T08:39:14Z 604.08MB <physical> success [restore_to_time: 2025-12-04T08:39:16]
2025-12-04T08:38:44Z 94.38KB <logical> success [restore_to_time: 2025-12-04T08:38:48]
Maybe we can have like this to keep compact style:
Snapshots:
2025-12-04T08:44:05Z 606.92MB <physical, this is one...> success [restore_to_time: 2025-12-04T08:44:07]
2025-12-04T08:40:54Z 605.09MB <physical, gcs> success [restore_to_time: 2025-12-04T08:40:57]
But I am not sure, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add it, but I wouldn't expect this to be a common problem (nobody sensible is going to name their profile like that). If they do then it's not really breaking anything it will just make their output not so nice.
I actually decided to ignore that part on purpose and wanted to know if this is something you would find useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it as it is now then.
pbm listpbm statusstorageNametoprofilein json output ofpbm listandpbm statusstrageNametoprofilein output ofpbm describe-backupstorageTypeto output ofpbm describe-backup