✨ Add multiple expenses via bank transactions at the same time #477
Conversation
| return ( | ||
| <BankingTransactionList | ||
| add={addViaBankTransaction} | ||
| // addMultipleExpenses={addMultipleExpenses} | ||
| // multipleTransactions={multipleTransactions} | ||
| // setMultipleTransactions={handleSetMultipleTransactions} | ||
| // isTransactionLoading={isTransactionLoading} | ||
| addAllMultipleExpenses={addAllMultipleExpenses} | ||
| addOneByOneMultipleExpenses={addOneByOneMultipleExpenses} | ||
| multipleTransactions={multipleTransactions} | ||
| setMultipleTransactions={handleSetMultipleTransactions} | ||
| isTransactionLoading={isTransactionLoading} | ||
| bankConnectionEnabled={bankConnectionEnabled} | ||
| // clearFields={clearFields} | ||
| clearFields={clearFields} | ||
| > | ||
| {children} | ||
| </BankingTransactionList> |
There was a problem hiding this comment.
I don't really get the point of this component. It's just prop drilling with no UI added? Why not merge it with BankTransactionList?
There was a problem hiding this comment.
It's because BankingTransactionList is a bit large. and that the bankTransactionList should be kept more pure if the function used is outside. If you have a strong opinion about this I can change it otherwise I think this is more neat.
src/components/AddExpense/BankTransactions/BankTransactionItem.tsx
Outdated
Show resolved
Hide resolved
|
Regarding the dialog text, I would change it to:
|
|
One more thing, can you bump the axios and form-data deps introduced by |
2 participants
Description
Have implemented add multiple expenses via bank transactions at the same time.
Both one by one so you can edit them separate or add all at the same time.
@krokosik Please help me with the text on the modal.
Demo
Nov-08-2025.15-13-501.mp4
Checklist
CONTRIBUTING.mdin its entirety