many: drop Exports() from imagetypes and use the manifest
#1735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These calls are unnecessary because the imagePipeline already has the Filename(). They are also "wrong" in some sense because it should be the images function should decide what is exported.
The image functions already mark the exported artifacts so we do not need this information in the image types.
The images functions already know what is exported so drop duplicating this from the imagetypes and use the manifest instead.
Contributor
|
This PR changes the images API or behaviour causing integration failures with osbuild-composer. The next update of the images dependency in osbuild-composer will need work to adapt to these changes. This is simply a notice. It will not block this PR from being merged. |
Member
|
Related: #1738 |
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[draft as it needs consensus first and also needs updates to ibcli/composer, based on the excellent suggestion from @achilleas-k - there is also the question how this will fit with bootc/bib, see https://github.com//pull/1736 which has exports for all of raw/qcow2/etc currently, this side also needs tweaks probably a selector in the images function]
This PR removes the
distro.ImageType.Exports()method and replaces it with themanifest.Exports().