fix: quality

Author: xitij2000

openedx/core/djangoapps/agreements/admin.py

@@ -3,10 +3,14 @@
 """
 
 from django.contrib import admin
-from openedx.core.djangoapps.agreements.models import IntegritySignature, UserAgreement
-from openedx.core.djangoapps.agreements.models import LTIPIITool
-from openedx.core.djangoapps.agreements.models import LTIPIISignature
-from openedx.core.djangoapps.agreements.models import ProctoringPIISignature
+
+from openedx.core.djangoapps.agreements.models import (
+    IntegritySignature,
+    LTIPIISignature,
+    LTIPIITool,
+    ProctoringPIISignature,
+    UserAgreement
+)
 
 
 class IntegritySignatureAdmin(admin.ModelAdmin):

openedx/core/djangoapps/agreements/api.py

@@ -10,8 +10,17 @@
 from django.core.exceptions import ObjectDoesNotExist
 from opaque_keys.edx.keys import CourseKey
 
-from .data import LTIPIISignatureData, LTIToolsReceivingPIIData, UserAgreementRecordData
-from .models import IntegritySignature, LTIPIISignature, LTIPIITool, UserAgreementRecord
+from openedx.core.djangoapps.agreements.data import (
+    LTIPIISignatureData,
+    LTIToolsReceivingPIIData,
+    UserAgreementRecordData
+)
+from openedx.core.djangoapps.agreements.models import (
+    IntegritySignature,
+    LTIPIISignature,
+    LTIPIITool,
+    UserAgreementRecord
+)
 
 log = logging.getLogger(__name__)
 User = get_user_model()

openedx/core/djangoapps/agreements/data.py

@@ -6,7 +6,7 @@
 
 import attr
 
-from .models import UserAgreementRecord, UserAgreement
+from openedx.core.djangoapps.agreements.models import UserAgreement, UserAgreementRecord
 
 
 @attr.s(frozen=True, auto_attribs=True)
@@ -28,7 +28,6 @@ class LTIPIISignatureData:
     lti_tools_hash: str
 
 
-
 @dataclass
 class UserAgreementData:
     """
@@ -37,8 +36,8 @@ class UserAgreementData:
     type: str
     name: str
     summary: str
-    text: str|None
-    url: str|None
+    text: str | None
+    url: str | None
 
     @classmethod
     def from_model(cls, model: UserAgreement):
@@ -50,6 +49,7 @@ def from_model(cls, model: UserAgreement):
             url=model.url
         )
 
+
 @dataclass
 class UserAgreementRecordData:
     """

openedx/core/djangoapps/agreements/serializers.py

@@ -3,10 +3,9 @@
 """
 from rest_framework import serializers
 
+from openedx.core.djangoapps.agreements.models import IntegritySignature, LTIPIISignature
 from openedx.core.lib.api.serializers import CourseKeyField
 
-from .models import IntegritySignature, LTIPIISignature
-
 
 class IntegritySignatureSerializer(serializers.ModelSerializer):
     """

openedx/core/djangoapps/agreements/tests/test_api.py

@@ -9,22 +9,21 @@
 from testfixtures import LogCapture
 
 from common.djangoapps.student.tests.factories import UserFactory
-from openedx.core.djangolib.testing.utils import skip_unless_lms
-from xmodule.modulestore.tests.django_utils import SharedModuleStoreTestCase
-from xmodule.modulestore.tests.factories import CourseFactory
-
-from ..api import (
+from openedx.core.djangoapps.agreements.api import (
     create_integrity_signature,
     create_lti_pii_signature,
     create_user_agreement_record,
     get_integrity_signature,
     get_integrity_signatures_for_course,
+    get_latest_user_agreement_record,
     get_lti_pii_signature,
     get_pii_receiving_lti_tools,
-    get_latest_user_agreement_record,
     get_user_agreement_records
 )
-from ..models import LTIPIITool
+from openedx.core.djangoapps.agreements.models import LTIPIITool
+from openedx.core.djangolib.testing.utils import skip_unless_lms
+from xmodule.modulestore.tests.django_utils import SharedModuleStoreTestCase
+from xmodule.modulestore.tests.factories import CourseFactory
 
 LOGGER_NAME = "openedx.core.djangoapps.agreements.api"
 

openedx/core/djangoapps/agreements/tests/test_models.py

@@ -4,6 +4,7 @@
 
 from django.db import IntegrityError
 from django.test import TestCase
+
 from openedx.core.djangoapps.agreements.models import UserAgreement
 
 

openedx/core/djangoapps/agreements/tests/test_views.py

@@ -14,16 +14,15 @@
 
 from common.djangoapps.student.roles import CourseStaffRole
 from common.djangoapps.student.tests.factories import AdminFactory, UserFactory
-from openedx.core.djangolib.testing.utils import skip_unless_lms
-from xmodule.modulestore.tests.django_utils import ModuleStoreTestCase
-from xmodule.modulestore.tests.factories import CourseFactory
-
-from ..api import (
+from openedx.core.djangoapps.agreements.api import (
     create_integrity_signature,
     create_user_agreement_record,
     get_integrity_signatures_for_course,
     get_lti_pii_signature
 )
+from openedx.core.djangolib.testing.utils import skip_unless_lms
+from xmodule.modulestore.tests.django_utils import ModuleStoreTestCase
+from xmodule.modulestore.tests.factories import CourseFactory
 
 
 @skip_unless_lms

openedx/core/djangoapps/agreements/toggles.py

@@ -3,6 +3,7 @@
 """
 
 from opaque_keys.edx.keys import CourseKey
+
 from openedx.core.djangoapps.waffle_utils import CourseWaffleFlag
 
 # .. toggle_name: agreements.enable_lti_pii_acknowledgement

openedx/core/djangoapps/agreements/urls.py

@@ -6,7 +6,12 @@
 from django.urls import path, re_path
 from rest_framework.routers import DefaultRouter
 
-from .views import IntegritySignatureView, LTIPIISignatureView, UserAgreementRecordsView, UserAgreementsViewSet
+from openedx.core.djangoapps.agreements.views import (
+    IntegritySignatureView,
+    LTIPIISignatureView,
+    UserAgreementRecordsView,
+    UserAgreementsViewSet
+)
 
 router = DefaultRouter()
 router.register(r'agreement', UserAgreementsViewSet, basename='user_agreements')

openedx/core/djangoapps/agreements/views.py

@@ -14,18 +14,21 @@
 
 from common.djangoapps.student import auth
 from common.djangoapps.student.roles import CourseStaffRole
-
-from .api import (
+from openedx.core.djangoapps.agreements.api import (
     create_integrity_signature,
     create_lti_pii_signature,
     create_user_agreement_record,
     get_integrity_signature,
     get_latest_user_agreement_record
 )
-from .models import UserAgreement
-from .serializers import IntegritySignatureSerializer, LTIPIISignatureSerializer, UserAgreementRecordSerializer, \
+from openedx.core.djangoapps.agreements.models import UserAgreement
+from openedx.core.djangoapps.agreements.serializers import (
+    IntegritySignatureSerializer,
+    LTIPIISignatureSerializer,
+    UserAgreementRecordSerializer,
     UserAgreementSerializer
-from ...lib.api.view_utils import view_auth_classes
+)
+from openedx.core.lib.api.view_utils import view_auth_classes
 
 
 def is_user_course_or_global_staff(user, course_id):