fix: default enum member value to id#1444
Open
nanookclaw wants to merge 3 commits into
Open
Conversation
Signed-off-by: Nanook <nanookclaw@users.noreply.github.com>
7447e92 to
b13fd2a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1444 +/- ##
=====================================
Coverage 82.2% 82.2%
=====================================
Files 125 125
Lines 10241 10249 +8
=====================================
+ Hits 8423 8431 +8
Misses 1818 1818 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Nanook <nanookclaw@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Enum member deserialization now accepts entries without an explicit
valuefield and fills the publicEnumEntriesSpec.valuewith the memberid. Explicitvaluefields are still preserved.This keeps downstream code working with a concrete
ValueSpecwhile matching the semantic convention schema behavior described in #733.Closes #733.
Verification
cargo test -p weaver_semconv test_enum_member_value_defaults_to_idcargo test -p weaver_semconv