fix(gen): distinct wrapper types for shared body with differing headers#1679
Merged
ernado merged 1 commit intoMay 30, 2026
Merged
Conversation
Widen the wtypes cache key to include the response header set so operations sharing a body schema but declaring different headers no longer collapse into one wrapper. When the schema-derived name is already claimed by a wrapper with a different header set, fall back to the operation-specific name to avoid a type-name conflict.
ernado
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widen the
wtypescache key to include the response header set so operations sharing a body schema but declaring different headers no longer collapse into one wrapper. When the schema-derived name is already claimed by a wrapper with a different header set, fall back to the operation-specific name to avoid a type-name conflict.I chose to intern the header keys as a
jsonschema.Refvs adding a non-jsonschema.Refvalue to the key, which would have been a larger change. I can propose a distinctwtypeKeytype if that's preferable.