Skip to content

[FEAT]: Return Octokit::TooManyRequests on 429 http error #1772

@sarenrae-dev

Description

@sarenrae-dev

Describe the need

Currently when the github api returns a 403 error with a message about rate limits octokit returns Octokit::TooManyRequests

Ive realized that at the very least with the sbom endpoint the api actually returns a 429 error when you reach the rate limit.

as it currently stands this is handled by octokit by returning the more generic Octokit::ClientError.
Since you already have the Octokit::TooManyRequests error implemented, perhaps explicitely returning it on status code 429 could be helpful

SDK Version

No response

API Version

No response

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    Status: TriageThis is being looked at and prioritizedType: FeatureNew feature or request

    Type

    No type

    Projects

    Status

    🆕 Triage

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions