-
Notifications
You must be signed in to change notification settings - Fork 13
Description
Just migrated to v1 for Nx Cloud.
2 cents from me:
Providing imageRegistry globally
Right now using mirror registry requires setting explicit image registry (with repository and image name itself) on every service seperately.
Instead of:
global:
imageTag: '2025.07.2'
frontend:
image:
repository: "example.com/nxprivatecloud/nx-cloud-frontend"
api:
image:
repository: "example.com/nxprivatecloud/nx-cloud-nx-api"
aggregator:
image:
repository: "example.com/nxprivatecloud/nx-cloud-aggregator"It would be nice to have just:
global:
imageTag: '2025.07.2'
imageRegistry: 'example.com'Need for service accounts
Once service accounts creation is disabled different services still have references of serviceAccountName. So either services can be created with the chart or outside of it, but it is not possible to run with default service account.
Missing details in migration
- Details from
deployment.envhas to be moved toapi.valkey NX_CLOUD_MONGO_SERVER_ENDPOINTcan be set viaglobal.mongodbConnectionString
Valkey configMap should affect services where it is references
This is usually done by adding content sha of configMap as annotation to the service. This way changes in configMap forces services to be updated with next deployment as well.
Api service used to work just with primary address of Valkey
Before api service worked just with VALKEY_PRIMARY_ADDRESS being set. With v1 chart (the same version if container images) api pods fail when only api.valkey.primaryAddress is set, it requires api.valkey.replicaAddresses being provided. This could be mentioned in migration.