Merge branch 'slejm/Player-RemoveItem-fix' into 'dev'

davidsebesta1 · davidsebesta1 · commit b84ee87f7c29 · 2026-03-03T13:09:51.000+01:00
Fix Player.RemoveItem inventory bug

See merge request SCPSL/LabAPI-Internal!338
diff --git a/LabApi/Features/Wrappers/Players/Player.cs b/LabApi/Features/Wrappers/Players/Player.cs
@@ -1481,9 +1481,11 @@ public void IntercomUnmute(bool revokeMute)
     public void RemoveItem(ItemType item, int maxAmount = 1)
     {
         int count = 0;
-        for (int i = 0; i < Items.Count(); i++)
+        Item[] items = Items.ToArray();
+        for (int i = 0; i < items.Length; i++)
         {
-            ItemBase? itemBase = Items.ElementAt(i).Base;
+            ItemBase itemBase = items[i].Base;
+
             if (itemBase.ItemTypeId != item)
             {
                 continue;

Original file line number	Diff line number	Diff line change
`@@ -1481,9 +1481,11 @@ public void IntercomUnmute(bool revokeMute)`
`1481`	`1481`	`public void RemoveItem(ItemType item, int maxAmount = 1)`
`1482`	`1482`	`{`
`1483`	`1483`	`int count = 0;`
`1484`		`- for (int i = 0; i < Items.Count(); i++)`
	`1484`	`+ Item[] items = Items.ToArray();`
	`1485`	`+ for (int i = 0; i < items.Length; i++)`
`1485`	`1486`	`{`
`1486`		`- ItemBase? itemBase = Items.ElementAt(i).Base;`
	`1487`	`+ ItemBase itemBase = items[i].Base;`
	`1488`	`+`
`1487`	`1489`	`if (itemBase.ItemTypeId != item)`
`1488`	`1490`	`{`
`1489`	`1491`	`continue;`