OPtimize storing zero page image in WAL as FPI

Author: knizhnik

src/backend/access/transam/xloginsert.c

@@ -638,22 +638,30 @@ XLogRecordAssemble(RmgrId rmid, uint8 info,
 			 */
 			if (regbuf->flags & REGBUF_STANDARD)
 			{
-				/* Assume we can omit data between pd_lower and pd_upper */
-				uint16		lower = ((PageHeader) page)->pd_lower;
-				uint16		upper = ((PageHeader) page)->pd_upper;
-
-				if (lower >= SizeOfPageHeaderData &&
-					upper > lower &&
-					upper <= BLCKSZ)
+				if (PageIsNew(page))
 				{
-					bimg.hole_offset = lower;
-					cbimg.hole_length = upper - lower;
+					bimg.hole_offset = 0;
+					cbimg.hole_length = BLCKSZ;
 				}
 				else
 				{
-					/* No "hole" to remove */
-					bimg.hole_offset = 0;
-					cbimg.hole_length = 0;
+					/* Assume we can omit data between pd_lower and pd_upper */
+					uint16		lower = ((PageHeader) page)->pd_lower;
+					uint16		upper = ((PageHeader) page)->pd_upper;
+
+					if (lower >= SizeOfPageHeaderData &&
+						upper > lower &&
+						upper <= BLCKSZ)
+					{
+						bimg.hole_offset = lower;
+						cbimg.hole_length = upper - lower;
+					}
+					else
+					{
+						/* No "hole" to remove */
+						bimg.hole_offset = 0;
+						cbimg.hole_length = 0;
+					}
 				}
 			}
 			else

src/backend/access/transam/xlogreader.c

@@ -1873,7 +1873,9 @@ DecodeXLogRecord(XLogReaderState *state,
 				if ((blk->bimg_info & BKPIMAGE_HAS_HOLE) &&
 					(blk->hole_offset == 0 ||
 					 blk->hole_length == 0 ||
-					 blk->bimg_len == BLCKSZ))
+					 blk->bimg_len == BLCKSZ) &&
+					!(blk->hole_offset == 0 &&
+					  blk->hole_length == BLCKSZ)) /* null page */
 				{
 					report_invalid_record(state,
 										  "BKPIMAGE_HAS_HOLE set, but hole offset %u length %u block image length %u at %X/%X",