fix: dockerfile template #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarioCadenas
force-pushed
the
fix-dockerfile
branch
from
1d2e8b5 to
fa9016f
Compare
MarioCadenas
force-pushed
the
fix-dockerfile
branch
from
fa9016f to
b5ef29c
Compare
arsenyinfo
reviewed
May 16, 2025
arsenyinfo
approved these changes
May 16, 2025
| EXPOSE ${SERVER_PORT} 80 | ||
|
|
||
| CMD ["/usr/bin/supervisord", "-c", "/etc/supervisord.conf"] | ||
| CMD ["sh", "-c", "bun db:push && /usr/bin/supervisord -c /etc/supervisord.conf"] |
Collaborator
There was a problem hiding this comment.
should they be separated?
Contributor
Author
There was a problem hiding this comment.
I think you can only run one command when using CMD right? and we need to run both of them, any suggestions?
Collaborator
There was a problem hiding this comment.
ah, i just realized it can't be RUN as db is not initialized during build. Should be fine than!
Co-authored-by: Arseny Kravchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.