Update to python 3.7 and latest nuklear#1
Open
creikey wants to merge 8 commits into
Open
Conversation
Everything except the overview translated to python seems to work
perfectly. The biggest change between versions was that now with
every string on cffi you have to do "test".encode('utf-8') instead
of just using a string in a cffi function like "test". I have not
found a way to mitigate this issue so far. This change in encoding
practice with cffi is the source of almost all braking in
overview.py. I used a vim regex command to add encode('utf-8') to
all strings that aren't doc strings, but there are several issues
still present and undiscovered, and can only be discovered by
running overview and pressing on random buttons.
Author
|
Seems not to be building on travis... |
Author
|
Ok everything seems to be building now, had to remove some stuff with sed in a makefile |
Author
|
So it turns out that you can use |
Owner
|
Hi, Thanks for contributing this! Python 3 support would be fantastic. I've not got a vast amount of free time at the moment so it might be a little while before i can look at merging your changes. A few things stick out at me that probably mean i cant merge it in its current form
I'll try to find the time to take a closer look as soon as i can. Thanks Nathan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Everything except the overview translated to python seems to work
perfectly. The biggest change between versions was that now with
every string on cffi you have to do "test".encode('utf-8') instead
of just using a string in a cffi function like "test". I have not
found a way to mitigate this issue so far. This change in encoding
practice with cffi is the source of almost all breaking in
overview.py. I used a vim regex command to add encode('utf-8') to
all strings that aren't doc strings, but there are several issues
still present and undiscovered, and can only be discovered by
running overview and pressing on random buttons.