Commit 1ff13f5
authored
fix: Hide the xxx_sink variants from the public API (#123)
## Description
These functions are internal and have no business being in the public
API, I think
## Breaking Changes
Removes
- api::remote::Remote::fetch_sink
- api::remote::Remote::execute_push_sink
- api::remote::Remote::execute_get_sink
## Notes & open questions
Note: maybe we need to expose them at some point, but currently I don't
see the need, and in any case the Sink trait is not exposed, so nobody
can use them anyway at this time!
## Change checklist
- [ ] Self-review.
- [ ] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.
- [ ] Tests if relevant.
- [ ] All breaking changes documented.1 parent 8eb5733 commit 1ff13f5
1 file changed
+3
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
499 | 499 | | |
500 | 500 | | |
501 | 501 | | |
502 | | - | |
| 502 | + | |
503 | 503 | | |
504 | 504 | | |
505 | 505 | | |
| |||
573 | 573 | | |
574 | 574 | | |
575 | 575 | | |
576 | | - | |
| 576 | + | |
577 | 577 | | |
578 | 578 | | |
579 | 579 | | |
| |||
654 | 654 | | |
655 | 655 | | |
656 | 656 | | |
657 | | - | |
| 657 | + | |
658 | 658 | | |
659 | 659 | | |
660 | 660 | | |
| |||
0 commit comments