Skip to content

Commit e5befe4

Browse files
committed
A few minor changes in response to the copilot review of astropy#191
1 parent d8227f4 commit e5befe4

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

astrowidgets/bqplot.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ def data_aspect_ratio(self):
114114
"""
115115
Aspect ratio of the image data, horizontal size over vertical size.
116116
"""
117-
return self._image_shape[0] / self._image_shape[1]
117+
return self._image_shape[1] / self._image_shape[0]
118118

119119
def reset_scale_to_fit_image(self):
120120
wide = self.data_aspect_ratio < 1
@@ -467,7 +467,7 @@ def _add_new_single_marker(self, x_mark, y_mark):
467467
marker_name,
468468
color=self.marker['color'],
469469
size=self.marker['radius']**2,
470-
style=self.marker['type'])
470+
shape=self.marker['type'])
471471

472472
# Update the viewport to match changes in the UI
473473
def _init_watch_image_changes(self):
@@ -499,8 +499,8 @@ def update_zoom_level(event):
499499
# or the minimum instead of the maximum is also fine.
500500
x_scale = self._astro_im._scales['x']
501501

502-
# THIS IS TERRIBLE AND MAKES THINGS SUPER LAGGY!!!! Needs to be
503-
# throttled or something. Look at the ImageGL observe options.
502+
# If things seem laggy in the future, check whether throtttling
503+
# the updates helps.
504504
x_scale.observe(update_zoom_level, names='max')
505505

506506
def _interval_and_stretch(self, stretch=None, cuts=None):

0 commit comments

Comments
 (0)