Skip to content

Conversation

@JCQuintas
Copy link
Member

@JCQuintas JCQuintas commented Nov 27, 2025

What do you think about moving these default setting to the selector?

This doesn't specifically bring any value, but it could technically allow us to use other selectors when defaulting

@JCQuintas JCQuintas self-assigned this Nov 27, 2025
@JCQuintas JCQuintas added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: charts Changes related to the charts. labels Nov 27, 2025
@mui-bot
Copy link

mui-bot commented Nov 27, 2025

Deploy preview: https://deploy-preview-20468--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts ▼-83B(-0.02%) ▼-12B(-0.01%)
@mui/x-charts-pro ▼-83B(-0.02%) ▼-26B(-0.02%)
@mui/x-charts-premium ▼-83B(-0.02%) ▼-2B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 5f30433

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 27, 2025

CodSpeed Performance Report

Merging #20468 will not alter performance

Comparing JCQuintas:defaultize-to-selector (5f30433) with master (8acbe5b)

Summary

✅ 13 untouched

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 28, 2025
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Nov 28, 2025
@JCQuintas JCQuintas changed the title [charts] Move to selector [charts] Move series default to selector Nov 28, 2025
@JCQuintas JCQuintas marked this pull request as ready for review November 28, 2025 12:12
@bernardobelchior
Copy link
Member

This doesn't specifically bring any value, but it could technically allow us to use other selectors when defaulting

Is there a use case for using selectors before setting the defaults?

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: out-of-date The pull request has merge conflicts and can't be merged. scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants