Refactor FXIOS-14344 [Swift 6 migration] Fixing warnings in unit tests (#31129)

Fix warnings in unit tests batch 4

Author: lmarceau

firefox-ios/firefox-ios-tests/Tests/ClientTests/Frontend/Browser/BrowserWebUIDelegateTests.swift

@@ -21,20 +21,20 @@ final class BrowserWebUIDelegateTests: XCTestCase {
         )
     }
 
-    override func setUp() {
-        super.setUp()
+    override func setUp() async throws {
+        try await super.setUp()
         DependencyHelperMock().bootstrapDependencies()
         let profile = MockProfile()
         LegacyFeatureFlagsManager.shared.initializeDeveloperFeatures(with: profile)
         engineResponder = MockWKUIHandler()
         mockLegacyResponder = MockLegacyResponder()
     }
 
-    override func tearDown() {
+    override func tearDown()  async throws {
         DependencyHelperMock().reset()
         engineResponder = nil
         mockLegacyResponder = nil
-        super.tearDown()
+        try await super.tearDown()
     }
 
     func testCreateWebView_respondsToEngineResponder() {

firefox-ios/firefox-ios-tests/Tests/ClientTests/Frontend/ContextualHints/ContextualHintEligibilityUtilityTests.swift

@@ -16,8 +16,8 @@ class ContextualHintEligibilityUtilityTests: XCTestCase {
     var urlBar: MockURLBarView!
     var overlayState: MockOverlayModeManager!
 
-    override func setUp() {
-        super.setUp()
+    override func setUp() async throws {
+        try await super.setUp()
 
         profile = MockProfile()
         urlBar = MockURLBarView()
@@ -28,14 +28,13 @@ class ContextualHintEligibilityUtilityTests: XCTestCase {
                                                    overlayState: nil)
     }
 
-    override func tearDown() {
-        super.tearDown()
-
+    override func tearDown() async throws {
         profile.shutdown()
         profile = nil
         urlBar = nil
         overlayState = nil
         subject = nil
+        try await super.tearDown()
     }
 
     // MARK: - Test should Present cases

firefox-ios/firefox-ios-tests/Tests/ClientTests/Frontend/ContextualHints/ContextualHintViewProviderTests.swift

@@ -13,15 +13,15 @@ class ContextualHintViewProviderTests: XCTestCase {
 
     private var profile: MockProfile!
 
-    override func setUp() {
-        super.setUp()
+    override func setUp() async throws {
         profile = MockProfile()
         LegacyFeatureFlagsManager.shared.initializeDeveloperFeatures(with: profile)
+        try await super.setUp()
     }
 
-    override func tearDown() {
-        super.tearDown()
+    override func tearDown() async throws {
         profile = nil
+        try await super.tearDown()
     }
 
     // MARK: Mark Contextual Hint Configuration

firefox-ios/firefox-ios-tests/Tests/ClientTests/Frontend/Homepage/ContextMenu/ContextMenuConfigurationTests.swift

@@ -8,6 +8,7 @@ import XCTest
 
 @testable import Client
 
+@MainActor
 final class ContextMenuConfigurationTests: XCTestCase {
     func tests_initialState_forMerinoItem_returnsExpectedState() {
         let merinoItem: HomepageItem = .merino(

firefox-ios/firefox-ios-tests/Tests/ClientTests/Frontend/Homepage/ContextMenu/ContextMenuCoordinatorTests.swift

@@ -12,16 +12,16 @@ import XCTest
 final class ContextMenuCoordinatorTests: XCTestCase {
     private var mockRouter: MockRouter!
 
-    override func setUp() {
-        super.setUp()
+    override func setUp() async throws {
+        try await super.setUp()
         DependencyHelperMock().bootstrapDependencies()
         mockRouter = MockRouter(navigationController: MockNavigationController())
     }
 
-    override func tearDown() {
+    override func tearDown() async throws {
         mockRouter = nil
         DependencyHelperMock().reset()
-        super.tearDown()
+        try await super.tearDown()
     }
 
     func test_initialState() {

firefox-ios/firefox-ios-tests/Tests/ClientTests/Frontend/Homepage/HomepageDiffableDataSourceTests.swift

@@ -8,13 +8,13 @@ import MozillaAppServices
 
 @testable import Client
 
+@MainActor
 final class HomepageDiffableDataSourceTests: XCTestCase {
     var collectionView: UICollectionView?
     var diffableDataSource: HomepageDiffableDataSource?
 
-    override func setUpWithError() throws {
-        try super.setUpWithError()
-
+    override func setUp() async throws {
+        try await super.setUp()
         collectionView = UICollectionView(frame: .zero, collectionViewLayout: UICollectionViewFlowLayout())
         let collectionView = try XCTUnwrap(collectionView)
         diffableDataSource = HomepageDiffableDataSource(
@@ -26,11 +26,11 @@ final class HomepageDiffableDataSourceTests: XCTestCase {
         LegacyFeatureFlagsManager.shared.initializeDeveloperFeatures(with: MockProfile())
     }
 
-    override func tearDown() {
+    override func tearDown() async throws {
         diffableDataSource = nil
         collectionView = nil
         DependencyHelperMock().reset()
-        super.tearDown()
+        try await super.tearDown()
     }
 
     // MARK: - applyInitialSnapshot

firefox-ios/firefox-ios-tests/Tests/ClientTests/Frontend/Homepage/HomepageViewControllerTests.swift

@@ -14,20 +14,20 @@ final class HomepageViewControllerTests: XCTestCase, StoreTestUtility {
     var mockStore: MockStoreForMiddleware<AppState>!
     var mockThrottler: MockThrottler!
 
-    override func setUp() {
-        super.setUp()
+    override func setUp() async throws {
+        try await super.setUp()
         LegacyFeatureFlagsManager.shared.initializeDeveloperFeatures(with: MockProfile())
         DependencyHelperMock().bootstrapDependencies()
         setupStore()
     }
 
-    override func tearDown() {
+    override func tearDown() async throws {
         mockThrottler = nil
         mockNotificationCenter = nil
         mockThemeManager = nil
         DependencyHelperMock().reset()
         resetStore()
-        super.tearDown()
+        try await super.tearDown()
     }
 
     // MARK: - Initial State

firefox-ios/firefox-ios-tests/Tests/ClientTests/Frontend/Homepage/PrivateHomepageViewControllerTests.swift

@@ -7,6 +7,7 @@ import Common
 
 @testable import Client
 
+@MainActor
 final class PrivateHomepageViewControllerTests: XCTestCase {
     let windowUUID: WindowUUID = .XCTestDefaultUUID
 

firefox-ios/firefox-ios-tests/Tests/ClientTests/Frontend/Homepage/Redux/BookmarksMiddlewareTests.swift

@@ -11,18 +11,18 @@ final class BookmarksMiddlewareTests: XCTestCase, StoreTestUtility {
     var mockProfile: MockProfile!
     var mockStore: MockStoreForMiddleware<AppState>!
 
-    override func setUp() {
-        super.setUp()
+    override func setUp() async throws {
+        try await super.setUp()
         mockProfile = MockProfile()
         DependencyHelperMock().bootstrapDependencies()
         setupStore()
     }
 
-    override func tearDown() {
+    override func tearDown() async throws {
         mockProfile = nil
         DependencyHelperMock().reset()
         resetStore()
-        super.tearDown()
+        try await super.tearDown()
     }
 
     func test_initializeAction_getBookmarksData() throws {

firefox-ios/firefox-ios-tests/Tests/ClientTests/Frontend/Homepage/Redux/HomepageMiddlewareTests.swift

@@ -13,21 +13,21 @@ final class HomepageMiddlewareTests: XCTestCase, StoreTestUtility {
     var mockStore: MockStoreForMiddleware<AppState>!
     var mockNotificationCenter: MockNotificationCenter!
 
-    override func setUp() {
-        super.setUp()
+    override func setUp() async throws {
+        try await super.setUp()
         mockGleanWrapper = MockGleanWrapper()
         mockNotificationCenter = MockNotificationCenter()
         DependencyHelperMock().bootstrapDependencies()
         LegacyFeatureFlagsManager.shared.initializeDeveloperFeatures(with: MockProfile())
         setupStore()
     }
 
-    override func tearDown() {
+    override func tearDown() async throws {
         DependencyHelperMock().reset()
         mockGleanWrapper = nil
         mockNotificationCenter = nil
         resetStore()
-        super.tearDown()
+        try await super.tearDown()
     }
 
     func test_init_setsUpNotifications() {