Skip to content

Conversation

@sigfault-byte
Copy link

Summary

This patch fixes a typo in the function name IsConsideredSameOriginForUIR, correcting it to IsConsideredSameOriginForURI.

Steps taken

To locate and update all references, I used:

grep -rnw ./ -e "IsConsideredSameOriginForUIR"
->
 ./docshell/base/nsDocShell.cpp:10160:      if (nsContentSecurityUtils::IsConsideredSameOriginForUIR(
./netwerk/protocol/http/HttpBaseChannel.cpp:4477:            nsContentSecurityUtils::IsConsideredSameOriginForUIR(
./dom/security/nsContentSecurityUtils.h:36:  static bool IsConsideredSameOriginForUIR(nsIPrincipal* aTriggeringPrincipal,
./dom/security/nsContentSecurityUtils.cpp:60:// Helper function for IsConsideredSameOriginForUIR which makes //in comment

Fix the typo in located files

grep -rnw ./ -e "IsConsideredSameOriginForUIR"  #No Results
grep -rnw ./ -e "IsConsideredSameOriginForURI" #Updated usages
-> 
./docshell/base/nsDocShell.cpp:10160:      if (nsContentSecurityUtils::IsConsideredSameOriginForURI(
./netwerk/protocol/http/HttpBaseChannel.cpp:4477:            nsContentSecurityUtils::IsConsideredSameOriginForURI(
./dom/security/nsContentSecurityUtils.h:36:  static bool IsConsideredSameOriginForURI(nsIPrincipal* aTriggeringPrincipal,
./dom/security/nsContentSecurityUtils.cpp:60:// Helper function for IsConsideredSameOriginForURI which makes
./dom/security/nsContentSecurityUtils.cpp:90:bool nsContentSecurityUtils::IsConsideredSameOriginForURI(

…nForURI

Used grep to locate all references:
  grep -rnw ./ -e IsConsideredSameOriginForUIR

  ./docshell/base/nsDocShell.cpp:10160
  ./netwerk/protocol/http/HttpBaseChannel.cpp:4477
  ./dom/security/nsContentSecurityUtils.h:36
  ./dom/security/nsContentSecurityUtils.cpp:60
  ./dom/security/nsContentSecurityUtils.cpp:90

Updated:
- Function declaration (.h)
- Function definition and comment (.cpp)
- All call sites
@github-actions
Copy link
Contributor

(Automated Close) Please do not file pull requests here, see https://firefox-source-docs.mozilla.org/contributing/how_to_submit_a_patch.html

@github-actions github-actions bot closed this May 14, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant