Replace magic number with a constant

Author: NGB-Was-Taken

app/src/main/java/mihon/app/shizuku/ShellInterface.kt

@@ -78,7 +78,7 @@ class ShellInterface : IShellInterface.Stub() {
             val installFlags = this::class.java.getField("installFlags")
             installFlags.set(
                 this,
-                installFlags.getInt(this) or 0x00000002, // android.content.pm.PackageManager.INSTALL_REPLACE_EXISTING
+                installFlags.getInt(this) or REPLACE_EXISTING_INSTALL_FLAG,
             )
 
             if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
@@ -119,18 +119,18 @@ class ShellInterface : IShellInterface.Stub() {
                 Long::class.java,
             ).invoke(session, "extension", 0L, apk.length) as ParcelFileDescriptor
             ).let { fd ->
-            val revocable = Class.forName("android.os.SystemProperties")
-                .getMethod("getBoolean", String::class.java, Boolean::class.java)
-                .invoke(null, "fw.revocable_fd", false) as Boolean
-
-            if (revocable) {
-                ParcelFileDescriptor.AutoCloseOutputStream(fd)
-            } else {
-                Class.forName($$"android.os.FileBridge$FileBridgeOutputStream")
-                    .getConstructor(ParcelFileDescriptor::class.java)
-                    .newInstance(fd) as OutputStream
+                val revocable = Class.forName("android.os.SystemProperties")
+                    .getMethod("getBoolean", String::class.java, Boolean::class.java)
+                    .invoke(null, "fw.revocable_fd", false) as Boolean
+
+                if (revocable) {
+                    ParcelFileDescriptor.AutoCloseOutputStream(fd)
+                } else {
+                    Class.forName($$"android.os.FileBridge$FileBridgeOutputStream")
+                        .getConstructor(ParcelFileDescriptor::class.java)
+                        .newInstance(fd) as OutputStream
+                }
             }
-        }
             .use { output ->
                 apk.createInputStream().use { input -> input.copyTo(output) }
             }
@@ -180,3 +180,7 @@ class ShellInterface : IShellInterface.Stub() {
         return shellContext.createPackageContext("com.android.shell", 0)
     }
 }
+
+// Constant hidden from the SDK
+// https://cs.android.com/android/platform/superproject/main/+/512046e84bcc51cc241bc6599f83ab345e93ab12:frameworks/base/core/java/android/content/pm/PackageManager.java;l=1682-1689
+private const val REPLACE_EXISTING_INSTALL_FLAG = 0x00000002