Fix review issues: disposed object return, unused field, resource leak, README

- Remove 'using' from CreateCommandWithMockGhAsync helpers that returned
  disposed ScriptToolCommand objects (PRScriptShellTests, PRScriptPowerShellTests)
- Remove unused _forceShowBuildOutput field and parameter from ScriptToolCommand
  (would cause CS0414 with TreatWarningsAsErrors)
- Add 'using' to HttpResponseMessage in ScriptHostFixture.InitializeAsync
- Fix README: integration tests use [OuterloopTest] not [ActiveIssue]
- Remove unrelated CI trigger pattern addition (create-failing-test-issue.*)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: radical

eng/testing/github-ci-trigger-patterns.txt

@@ -39,7 +39,6 @@ Aspire-Core.slnf
 .github/workflows/apply-test-attributes.yml
 .github/workflows/backmerge-release.yml
 .github/workflows/backport.yml
-.github/workflows/create-failing-test-issue.*
 .github/workflows/dogfood-comment.yml
 .github/workflows/generate-api-diffs.yml
 .github/workflows/generate-ats-diffs.yml

tests/Aspire.Acquisition.Tests/README.md

@@ -36,6 +36,6 @@ GH_TOKEN=<token> dotnet test tests/Aspire.Acquisition.Tests -- --filter-trait "C
 
 Integration tests (in `PRScriptIntegrationTests.cs`) query real GitHub PRs and are:
 
-- Disabled in CI via `[ActiveIssue]`
+- Excluded from default CI runs via `[OuterloopTest]` and `Category=integration` trait filters
 - Require `GH_TOKEN` environment variable
 - Skip gracefully if no suitable PR is found

tests/Aspire.Acquisition.Tests/Scripts/Common/ScriptHostFixture.cs

@@ -58,7 +58,7 @@ public async ValueTask InitializeAsync()
 
         // Verify the server is reachable
         using var client = new HttpClient();
-        var response = await client.GetAsync($"{BaseUrl}/get-aspire-cli.sh");
+        using var response = await client.GetAsync($"{BaseUrl}/get-aspire-cli.sh");
         if (!response.IsSuccessStatusCode)
         {
             throw new InvalidOperationException($"Script host failed to start: HTTP {response.StatusCode}");

tests/Aspire.Acquisition.Tests/Scripts/Common/ScriptToolCommand.cs

@@ -14,25 +14,21 @@ public class ScriptToolCommand : ToolCommand
 {
     private readonly string _scriptPath;
     private readonly TestEnvironment _testEnvironment;
-    private readonly bool _forceShowBuildOutput;
 
     /// <summary>
     /// Creates a new command to execute a script.
     /// </summary>
     /// <param name="scriptPath">Relative path to the script from repo root (e.g., "eng/scripts/get-aspire-cli.sh")</param>
     /// <param name="testEnvironment">Test environment providing isolated temp directories</param>
     /// <param name="testOutput">xUnit test output helper</param>
-    /// <param name="forceShowBuildOutput">Whether to force showing build output in the test results</param>
     public ScriptToolCommand(
         string scriptPath,
         TestEnvironment testEnvironment,
-        ITestOutputHelper testOutput,
-        bool forceShowBuildOutput = false)
+        ITestOutputHelper testOutput)
         : base(GetExecutable(scriptPath), testOutput, label: Path.GetFileName(scriptPath))
     {
         _scriptPath = scriptPath;
         _testEnvironment = testEnvironment;
-        _forceShowBuildOutput = forceShowBuildOutput;
 
         // Set mock HOME to prevent any accidental user directory access
         WithEnvironmentVariable("HOME", _testEnvironment.MockHome);

tests/Aspire.Acquisition.Tests/Scripts/PRScriptIntegrationTests.cs

@@ -36,7 +36,7 @@ public async Task ShellScript_WithRealPR_DryRun_Succeeds()
         }
 
         using var env = new TestEnvironment();
-        using var cmd = new ScriptToolCommand(ScriptPaths.PRShell, env, _testOutput, forceShowBuildOutput: true);
+        using var cmd = new ScriptToolCommand(ScriptPaths.PRShell, env, _testOutput);
 
         var result = await cmd.ExecuteAsync(
             _prFixture.PRNumber.ToString(),
@@ -57,7 +57,7 @@ public async Task PowerShellScript_WithRealPR_WhatIf_Succeeds()
         }
 
         using var env = new TestEnvironment();
-        using var cmd = new ScriptToolCommand(ScriptPaths.PRPowerShell, env, _testOutput, forceShowBuildOutput: true);
+        using var cmd = new ScriptToolCommand(ScriptPaths.PRPowerShell, env, _testOutput);
 
         var result = await cmd.ExecuteAsync(
             "-PRNumber", _prFixture.PRNumber.ToString(),
@@ -78,7 +78,7 @@ public async Task ShellScript_WithRealPR_DiscoverRunId_DryRun_Succeeds()
         }
 
         using var env = new TestEnvironment();
-        using var cmd = new ScriptToolCommand(ScriptPaths.PRShell, env, _testOutput, forceShowBuildOutput: true);
+        using var cmd = new ScriptToolCommand(ScriptPaths.PRShell, env, _testOutput);
 
         // Test automatic run ID discovery by only passing PR number
         var result = await cmd.ExecuteAsync(
@@ -99,7 +99,7 @@ public async Task PowerShellScript_WithRealPR_DiscoverRunId_WhatIf_Succeeds()
         }
 
         using var env = new TestEnvironment();
-        using var cmd = new ScriptToolCommand(ScriptPaths.PRPowerShell, env, _testOutput, forceShowBuildOutput: true);
+        using var cmd = new ScriptToolCommand(ScriptPaths.PRPowerShell, env, _testOutput);
 
         // Test automatic run ID discovery by only passing PR number
         var result = await cmd.ExecuteAsync(

tests/Aspire.Acquisition.Tests/Scripts/PRScriptPowerShellTests.cs

@@ -22,7 +22,7 @@ public class PRScriptPowerShellTests(ITestOutputHelper testOutput)
     private async Task<ScriptToolCommand> CreateCommandWithMockGhAsync(TestEnvironment env)
     {
         var mockGhPath = await env.CreateMockGhScriptAsync(_testOutput);
-        using var cmd = new ScriptToolCommand(s_scriptPath, env, _testOutput);
+        var cmd = new ScriptToolCommand(s_scriptPath, env, _testOutput);
         cmd.WithEnvironmentVariable("PATH", $"{mockGhPath}{Path.PathSeparator}{Environment.GetEnvironmentVariable("PATH")}");
         return cmd;
     }

tests/Aspire.Acquisition.Tests/Scripts/PRScriptShellTests.cs

@@ -19,7 +19,7 @@ public class PRScriptShellTests(ITestOutputHelper testOutput)
     private async Task<ScriptToolCommand> CreateCommandWithMockGhAsync(TestEnvironment env)
     {
         var mockGhPath = await env.CreateMockGhScriptAsync(_testOutput);
-        using var cmd = new ScriptToolCommand(s_scriptPath, env, _testOutput);
+        var cmd = new ScriptToolCommand(s_scriptPath, env, _testOutput);
         cmd.WithEnvironmentVariable("PATH", $"{mockGhPath}{Path.PathSeparator}{Environment.GetEnvironmentVariable("PATH")}");
         return cmd;
     }