How to proceed when PRs await feedback?

[DCEM]

Hi.

I’ve contributed some PRs and ideas that are currently awaiting feedback/decisions, even after following up:

• PR #6731: ParameterMixin - a proposal for a modular extension of parameters
• Contrib drivers PR #386, discussed in PR #262 - this is a Thorlabs driver implementation, where I’m looking for guidance on how to move forward.

Also, finishing up contrib drivers PR #387 depends on whether ParameterMixin will be integrated.

I’m not upset - if my approaches aren’t a fit, that’s totally fine. I’d just appreciate a response or decision so I can move forward or adjust accordingly.

Thanks for all your work!

[Jens Hedegaard Nielsen (jenshnielsen)]

DCEM I am really sorry but I am struggling a bit with keeping up with pr review. I promise it is not forgotten but I am just somewhat limited of the time I can commit to review and especially the bigger prs are hard to slot in.

[DCEM]

Jens Hedegaard Nielsen (@jenshnielsen), thank you for the reply!

No worries at all. I really like qcodes and just want to give back if my code is a good fit for the project. I also definitely don’t want to be annoying or add pressure.

If possible on your end, a quick “busy right now, bump in 3 months” (or similar) would help set my expectations. If something isn’t a fit or needs more work, that’s totally fine with me too.

David

[Jens Hedegaard Nielsen (jenshnielsen)]

DCEM for sure. I try to arrange to have a bit more time every week for open source code review. FYI I will be mostly away from qcodes the next 2 weeks thou