Posting a new paste can fail on ID collision

[mokurin000]

wastebin/crates/wastebin_server/src/handlers/insert/api.rs

Lines 40 to 50 in b63022b

	pub async fn post(
	State(db): State<Database>,
	Json(entry): Json<Entry>,
	) -> Result<Json<RedirectResponse>, JsonErrorResponse> {
	let id = Id::rand();
	let entry: write::Entry = entry.into();
	let path = format!("/{}", id.to_url_path(&entry));
	db.insert(id, entry).await.map_err(Error::Database)?;
	Ok(Json::from(RedirectResponse { path }))
	}

We may try to regenerate the id and re-insert in configurable times, avoid potential weird post failure.

[matze]

I remember a PR that did exactly that. I wonder what happened. I'll take care.

[cgzones]

Rebased #75

[matze]

Ah yeah, GitHub being shit at the moment and not always showing all the open PRs 🙈

[mokurin000]

I remember a PR that did exactly that. I wonder what happened. I'll take care.

I remember I've implemented such loop in the slug branch

[matze]

Fixed via #75. Not fixed in a theoretical sense because of the upper bound of 10 retries but realistically the chance is zero.