-
-
Notifications
You must be signed in to change notification settings - Fork 458
Open
Labels
good first issueEverything in "Help wanted", PLUS being relatively easy and straightforward to implement.Everything in "Help wanted", PLUS being relatively easy and straightforward to implement.help wantedCommunity contributors can implement thisCommunity contributors can implement thisreadyReady for implementationReady for implementationtype: maintenancework: frontendRelated to frontend code in the mathesar_ui directoryRelated to frontend code in the mathesar_ui directory
Description
Description
- Prior to Refactor table view system to use string-based column ids #4975, column ids were both numbers and strings based on the context. Eg., the table page used numbers and data explorer used strings.
- In Refactor table view system to use string-based column ids #4975, we decided to move all usage to string-based.
- We now use the
Numberconstructor in several places where columnId is expected to be a number.
- We now use the
- The Number constructor has this behaviour:
Number(null)andNumber("")return0.Number("randomstring")isNaN
- While this doesn't cause any visible issues, this might come back to affect us in the future, as it opens a number of possible edge cases, where
nullneeds to be supported.
Changes required
- The
Numberconstructor usages forcolumn.idshould be replaced with a utility which handles thenull, empty string, andNaNscenarios.
zackkrida
Metadata
Metadata
Assignees
Labels
good first issueEverything in "Help wanted", PLUS being relatively easy and straightforward to implement.Everything in "Help wanted", PLUS being relatively easy and straightforward to implement.help wantedCommunity contributors can implement thisCommunity contributors can implement thisreadyReady for implementationReady for implementationtype: maintenancework: frontendRelated to frontend code in the mathesar_ui directoryRelated to frontend code in the mathesar_ui directory