Add US calendar

[ghost]

In the US they use the Sunday / M / T / W / T / F / S calendar. Auto-detect the format and select it. Would be easy to implement with grid.

[lostdesign]

I quickly wrote the code for "Sunday as first":

const getCurrentWeekDates = (date) => {
  let week = []
  
  const locale = localStorage.lang ?? 'en-US'
  const weekStartOnSunday = ['en-US', 'en-CA', 'en-AU']
  
  const startOfWeek = DateTime
    .fromISO(date)
    .setLocale(locale)
    .startOf('week')

  for (let i = 0; i <= 6; i++) {
    let day = startOfWeek
      .plus({ 
        days: weekStartOnSunday.includes(locale) ? i-1 : i
      })
      .setLocale(locale)
    week.push({
      isoDate: day.toISODate(),
      day: day.toFormat('d'),
      weekDay: day.toFormat('EEE')
    })
  }
  return week
}

getCurrentWeekDates('2021-09-16')

This would give me the following calendar.

[
  {
    isoDate: '2021-09-12',
    day: '12',
    weekDay: 'Sun'
  },
  {
    isoDate: '2021-09-13',
    day: '13',
    weekDay: 'Mon'
  },
  {
    isoDate: '2021-09-14',
    day: '14',
    weekDay: 'Tue'
  },
  {
    isoDate: '2021-09-15',
    day: '15',
    weekDay: 'Wed'
  },
  {
    isoDate: '2021-09-16',
    day: '16',
    weekDay: 'Thu'
  },
  {
    isoDate: '2021-09-17',
    day: '17',
    weekDay: 'Fri'
  },
  {
    isoDate: '2021-09-18',
    day: '18',
    weekDay: 'Sat'
  }
]

This code would need to be added here

linked/src/store/modules/calendar/helper.js

Lines 38 to 56 in 57211f0

	/**
	* Returns an array of date strings in YYYY-mm-dd for the current active week
	*/
	const getCurrentWeekDates = (date) => {
	let week = []
	const startOfWeek = DateTime.fromISO(date).startOf('week')
	for (let i = 0; i <= 6; i++) {
	let day = startOfWeek
	.plus({ days: i })
	.setLocale(localStorage.lang ?? 'en-US')
	week.push({
	isoDate: day.toISODate(),
	day: day.toFormat('d'),
	weekDay: day.toFormat('EEE')
	})
	}
	return week
	}

and tested if the app still works as expected.

However, this may need a new setting for people that want to choose sundayAsFirst but speak russian for example. Which my code example does not account for - that'd need to be added somewhere. So need to look a bit deeper into this, since just using the new setting from the store might not be as easy and putting it into localStorage is a nono as all configuration must be saved in electron-store.

It's not impossible, so it might be added soon in one of the next releases.

Thanks for your feedback!

[lostdesign]

RE: Your idea with grid - may work visually but break the calendar as it would not have the right order anymore. This needs to be changed in the method I posted above.

[lostdesign]

RERE: If anyone wants to tackle it, feel free to - I hope my original message is clear enough to implement it with the requirements I'd expect.

[ghost]

With this code you could open a PR.

[lostdesign]

For the first part yeah, however just this very snipped I shared would force anyone on English to have a Sunday as First week, which not everybody would want. So a dedicated setting is mandatory.

But yes, if someone adds that, the PR can be opened right away. I may get to this change next week.

[ghost]

For the first part yeah, however just this very snipped I shared would force anyone on English to have a Sunday as First week, which not everybody would want. So a dedicated setting is mandatory.

But yes, if someone adds that, the PR can be opened right away. I may get to this change next week.

So an override setting. If set to None null or undefined, it will use the local preference. If set to monday or sunday, it will use those. So a typeof("string") calculation is enough. On the UI undefined should be called "Default - Monday" or "Default - Sunday"