Conversation
bentsku
approved these changes
Feb 10, 2026
There was a problem hiding this comment.
LGTM, nice addition and nice find!
Here's the docs about the Required and NotRequired types: https://typing.python.org/en/latest/spec/typeddict.html#required-notrequired
Edit: and the PEP: https://peps.python.org/pep-0655/
Might be worth noting that total=False can also have Required, but let's not get stricter 😅
Only have a few comments nit, and a thought about the testing 👍 nice fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #11 we shipped some support for non-total
TypedDict. In our implementation, we extend the original type of every attribute withstr. With this trick, the serialization layer can put a special marker for keys that are not present in the dictionary.TypedDictalso has the possibility to usetyping.NotRequiredto achieve something similar.For instance:
In this case, the
given_valuekey can be omitted, and the typechecker won't raise any concern.Transforming the class as follows won't be correct, since now
type_could be omitted, while it is not in the case in the original implementation.This PR implements the support for
typing.NotRequiredwith the same logic as #11.Closes PNX-601