Additional clang-tidy checks

Author: alan-george-lk

.github/workflows/builds.yml

@@ -657,7 +657,7 @@ jobs:
           files-changed-only: false
           lines-changed-only: false
           extensions: 'c,cpp,cc,cxx'
-          ignore: 'build-*|cpp-example-collection|client-sdk-rust|vcpkg_installed|src/tests|bridge/tests'
+          ignore: 'build-*|cpp-example-collection|client-sdk-rust|vcpkg_installed|src/tests|bridge/tests|src/room_event_converter.cpp'
           file-annotations: true
           thread-comments: update
           step-summary: true

src/audio_stream.cpp

@@ -212,8 +212,7 @@ void AudioStream::onFfiEvent(const FfiEvent &event) {
   }
   if (ase.has_frame_received()) {
     const auto &fr = ase.frame_received();
-    AudioFrame frame = AudioFrame::fromOwnedInfo(fr.frame());
-    AudioFrameEvent ev{std::move(frame)};
+    AudioFrameEvent ev{AudioFrame::fromOwnedInfo(fr.frame())};
     pushFrame(std::move(ev));
   } else if (ase.has_eos()) {
     pushEos();

src/data_track_stream.cpp

@@ -58,7 +58,7 @@ bool DataTrackStream::read(DataTrackFrame &out) {
   std::unique_lock<std::mutex> lock(mutex_);
   cv_.wait(lock, [this] { return frame_.has_value() || eof_ || closed_; });
 
-  if (closed_ || (!frame_.has_value() && eof_)) {
+  if (closed_ || !frame_.has_value()) {
     return false;
   }
 

src/e2ee.cpp

@@ -29,11 +29,11 @@ namespace livekit {
 namespace {
 
 std::string bytesToString(const std::vector<std::uint8_t> &v) {
-  return std::string(reinterpret_cast<const char *>(v.data()), v.size());
+  return {reinterpret_cast<const char *>(v.data()), v.size()};
 }
 
 std::vector<std::uint8_t> stringToBytes(const std::string &s) {
-  return std::vector<std::uint8_t>(s.begin(), s.end());
+  return {s.begin(), s.end()};
 }
 
 } // namespace

src/ffi_client.cpp

@@ -37,7 +37,7 @@ namespace livekit {
 namespace {
 
 std::string bytesToString(const std::vector<std::uint8_t> &b) {
-  return std::string(reinterpret_cast<const char *>(b.data()), b.size());
+  return {reinterpret_cast<const char *>(b.data()), b.size()};
 }
 
 inline void logAndThrow(const std::string &error_msg) {

src/room.cpp

@@ -297,7 +297,7 @@ void Room::setOnVideoFrameCallback(const std::string &participant_identity,
                                    VideoStream::Options opts) {
   if (subscription_thread_dispatcher_) {
     subscription_thread_dispatcher_->setOnVideoFrameCallback(
-        participant_identity, source, std::move(callback), std::move(opts));
+        participant_identity, source, std::move(callback), opts);
   }
 }
 
@@ -307,7 +307,7 @@ void Room::setOnVideoFrameCallback(const std::string &participant_identity,
                                    VideoStream::Options opts) {
   if (subscription_thread_dispatcher_) {
     subscription_thread_dispatcher_->setOnVideoFrameCallback(
-        participant_identity, track_name, std::move(callback), std::move(opts));
+        participant_identity, track_name, std::move(callback), opts);
   }
 }
 

src/room_proto_converter.cpp

@@ -400,7 +400,7 @@ SipDtmfReceivedEvent sipDtmfFromProto(const proto::DataPacketReceived &in,
                                       RemoteParticipant *participant) {
   SipDtmfReceivedEvent ev;
   ev.participant = participant;
-  ev.code = in.sip_dtmf().code();
+  ev.code = static_cast<int>(in.sip_dtmf().code());
   ev.digit = in.sip_dtmf().digit();
   return ev;
 }

src/rpc_error.cpp

@@ -49,12 +49,12 @@ proto::RpcError RpcError::toProto() const {
 
 RpcError RpcError::fromProto(const proto::RpcError &err) {
   // proto::RpcError.data() will return empty string if unset, which is fine.
-  return RpcError(err.code(), err.message(), err.data());
+  return {err.code(), err.message(), err.data()};
 }
 
 RpcError RpcError::builtIn(ErrorCode code, const std::string &data) {
   const char *msg = defaultMessageFor(code);
-  return RpcError(code, msg ? std::string(msg) : std::string{}, data);
+  return {code, msg ? std::string(msg) : std::string{}, data};
 }
 
 const char *RpcError::defaultMessageFor(ErrorCode code) {

src/video_utils.cpp

@@ -146,7 +146,7 @@ VideoFrame fromOwnedProto(const proto::OwnedVideoBuffer &owned) {
   if (src_ptr == 0) {
     throw std::runtime_error("fromOwnedProto: info.data_ptr is null");
   }
-  const auto *src = reinterpret_cast<const std::uint8_t *>(src_ptr);
+  const auto *src = reinterpret_cast<const std::uint8_t *>(src_ptr); // NOLINT(performance-no-int-to-ptr)
 
   std::memcpy(dst, src, dst_size);