fix(FR-3015): gate app-launch session-not-found message to managers below 26.4.4#7663
Draft
nowgnuesLee wants to merge 1 commit into
Draft
fix(FR-3015): gate app-launch session-not-found message to managers below 26.4.4#7663nowgnuesLee wants to merge 1 commit into
nowgnuesLee wants to merge 1 commit into
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage Report for react-coverage (./react)
File Coverage
|
||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves #7662 (FR-3015)
Summary
Follow-up to #7409 (FR-2586). That PR added a friendly "session not accessible" message when an app launch fails with a 404 / "session not found" — the common cause being an access-key (AK) mismatch, where the session was created under a different keypair than the one currently in use.
From manager 26.4.4 on, streaming session lookups are scoped by the owner's user id instead of the access key. A user's sessions are therefore reachable across all of their keypairs, so the AK-mismatch case the FR-2586 workaround targets no longer occurs on those managers. This PR version-gates the workaround so it only applies to managers below 26.4.4.
Implementation
packages/backend.ai-client/src/client.ts: register a new capability flagsession-app-by-user-uuid, enabled for managers>= 26.4.4in_updateSupportList().react/src/hooks/useBackendAIAppLauncher.tsx: gate the FR-2586 friendlyAppLaunchErrorbehind both conditions — the error is a session-not-found error and the manager lackssession-app-by-user-uuid:On 26.4.4+ the workaround is disabled and the original manager error surfaces unchanged.
Behavior matrix
Test Plan
Verification
bash scripts/verify.sh— Relay / Lint / Format / TypeScript all PASS. (The "Vite warmup paths" check fails on a clean checkout too because it resolves production-build artifacts that are absent withoutpnpm build; unrelated to this change.)Related