bugbot + reviewer handling

Author: dcruzeneil2

packages/managed-auth-react/src/lib/api.ts

@@ -169,6 +169,7 @@ export function submitSignInOption(
 export interface ManagedAuthStreamHandlers {
   onState: (data: ManagedAuthStateEventData) => void;
   onError: (error: ManagedAuthApiError) => void;
+  /** Fires only on graceful stream end (server closed the connection). Not called after onError. */
   onClose: () => void;
 }
 
@@ -232,7 +233,8 @@ export function streamManagedAuthEvents(
         let data = "";
         for (const line of raw.split(/\r\n|\r|\n/)) {
           if (line.startsWith("event: ")) eventType = line.slice(7);
-          else if (line.startsWith("data: ")) data = line.slice(6);
+          else if (line.startsWith("data: "))
+            data += (data ? "\n" : "") + line.slice(6);
         }
 
         if (eventType === "managed_auth_state" && data) {
@@ -252,7 +254,7 @@ export function streamManagedAuthEvents(
           } catch {
             /* fall through with default message */
           }
-          handlers.onError(new ManagedAuthApiError(message, 500, data, true));
+          handlers.onError(new ManagedAuthApiError(message, 0, data, true));
           controller.abort();
           return;
         }

packages/managed-auth-react/src/lib/types.ts

@@ -81,6 +81,7 @@ export interface ManagedAuthResponse {
   profile_name: string;
   flow_status: FlowStatus;
   flow_step: FlowStep;
+  flow_type?: "LOGIN" | "REAUTH" | null;
   discovered_fields?: DiscoveredField[] | null;
   pending_sso_buttons?: SSOButton[] | null;
   mfa_options?: MFAOption[] | null;
@@ -90,6 +91,9 @@ export interface ManagedAuthResponse {
   website_error?: string | null;
   error_message?: string | null;
   error_code?: string | null;
+  post_login_url?: string | null;
+  live_view_url?: string | null;
+  hosted_url?: string | null;
 }
 
 export type UIState =

packages/managed-auth-react/src/session/useManagedAuthSession.ts

@@ -1,6 +1,7 @@
 import { useCallback, useEffect, useRef, useState } from "react";
 import {
   exchangeHandoffCode,
+  ManagedAuthApiError,
   retrieveManagedAuth,
   streamManagedAuthEvents,
   submitFieldValues,
@@ -55,6 +56,7 @@ function mergeStateEvent(
     ...base,
     flow_status: ev.flow_status,
     flow_step: ev.flow_step,
+    flow_type: ev.flow_type ?? base.flow_type ?? null,
     discovered_fields: ev.discovered_fields ?? null,
     pending_sso_buttons: ev.pending_sso_buttons ?? null,
     mfa_options: ev.mfa_options ?? null,
@@ -63,6 +65,9 @@ function mergeStateEvent(
     website_error: ev.website_error ?? null,
     error_message: ev.error_message ?? null,
     error_code: ev.error_code ?? null,
+    post_login_url: ev.post_login_url ?? base.post_login_url ?? null,
+    live_view_url: ev.live_view_url ?? base.live_view_url ?? null,
+    hosted_url: ev.hosted_url ?? base.hosted_url ?? null,
   };
 }
 
@@ -79,6 +84,7 @@ export interface ManagedAuthSessionValue {
   state: ManagedAuthResponse | null;
   uiState: UIState;
   isSubmitting: boolean;
+  isReconnecting: boolean;
   submitError: string | null;
   initError: string | null;
   startFlow: () => void;
@@ -101,6 +107,7 @@ export function useManagedAuthSession(
   const [state, setState] = useState<ManagedAuthResponse | null>(null);
   const [uiState, setUIState] = useState<UIState>("prime");
   const [isSubmitting, setIsSubmitting] = useState(false);
+  const [isReconnecting, setIsReconnecting] = useState(false);
   const [submitError, setSubmitError] = useState<string | null>(null);
   const [initError, setInitError] = useState<string | null>(null);
 
@@ -156,6 +163,7 @@ export function useManagedAuthSession(
 
       const handleStateEvent = (ev: ManagedAuthStateEventData) => {
         reconnectAttemptsRef.current = 0;
+        setIsReconnecting(false);
         setSubmitError(null);
         const base = stateRef.current;
         if (!base) return;
@@ -186,6 +194,7 @@ export function useManagedAuthSession(
 
       const scheduleReconnect = () => {
         if (terminalRef.current) return;
+        setIsReconnecting(true);
         const attempt = reconnectAttemptsRef.current++;
         const delay = Math.min(
           RECONNECT_BASE_MS * Math.pow(2, attempt),
@@ -229,7 +238,8 @@ export function useManagedAuthSession(
           connectStream(t);
         } catch (err) {
           if (gen !== generationRef.current) return;
-          const status = (err as { status?: number })?.status;
+          const status =
+            err instanceof ManagedAuthApiError ? err.status : undefined;
           if (status === 401 || status === 410) {
             terminalRef.current = true;
             setUIState("expired");
@@ -437,6 +447,7 @@ export function useManagedAuthSession(
     state,
     uiState,
     isSubmitting,
+    isReconnecting,
     submitError,
     initError,
     startFlow,